Use require_or_load also with Rails 5 #1138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ed37e9e require_or_load was used again for Rails 3 and 4. This commit uses it also for Rails 5, as it was working before.
|
Ah, thanks for this! I thought it was working fine with Rails 5, but clearly I was wrong. I was trying to avoid I added a spec fix to your commit, rebased as 4f515ba - so, it's merged manually :) I'll get a new release out shortly! |
|
v4.3.2 is released :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ed37e9e
require_or_loadwas used again for Rails 3 and 4. This commit uses it also for Rails 5, as it was working before.See #764 (comment).