Updated to work with TS v3 #11

Merged
merged 8 commits into from Jan 7, 2014

Conversation

Projects
None yet
2 participants
@weetu
Collaborator

weetu commented Oct 31, 2013

This probably still needs some tweaks (especially the documentation), but the code works and the specs run. I couldn't figure out how to run the features, though.

@pat

This comment has been minimized.

Show comment Hide comment
@pat

pat Dec 28, 2013

Owner

Hi Timo

I realise this pull request has sat neglected for too long. Are you currently using it in production, and is it working well for you? If so, I'm keen to merge it in. I'm also tempted to give you commit rights to the repo, given I've not touched this gem in some time, and I'm certainly not using it. Any thoughts on that matter?

Owner

pat commented Dec 28, 2013

Hi Timo

I realise this pull request has sat neglected for too long. Are you currently using it in production, and is it working well for you? If so, I'm keen to merge it in. I'm also tempted to give you commit rights to the repo, given I've not touched this gem in some time, and I'm certainly not using it. Any thoughts on that matter?

@weetu

This comment has been minimized.

Show comment Hide comment
@weetu

weetu Jan 6, 2014

Collaborator

Hi,

Sorry for the delay in replying, also :) Yeah, we're using it in production, and it seems to work. Haven't encountered any problems.

I don't mind the commit rights, if you're willing to give them, but at the moment I'm not too keen to become the "official" administrator for this gem. Since I only have one day per week to use on the project where we use TS and ts-datetime-delta, I don't think I'll have the time to properly maintain this codebase for others (in case anyone else even uses this gem...). I'm also still thinking about implementing that other delta scheme I mentioned in some email ages ago, in which case I won't be using this gem either.

Collaborator

weetu commented Jan 6, 2014

Hi,

Sorry for the delay in replying, also :) Yeah, we're using it in production, and it seems to work. Haven't encountered any problems.

I don't mind the commit rights, if you're willing to give them, but at the moment I'm not too keen to become the "official" administrator for this gem. Since I only have one day per week to use on the project where we use TS and ts-datetime-delta, I don't think I'll have the time to properly maintain this codebase for others (in case anyone else even uses this gem...). I'm also still thinking about implementing that other delta scheme I mentioned in some email ages ago, in which case I won't be using this gem either.

pat added a commit that referenced this pull request Jan 7, 2014

Merge pull request #11 from weetu/master
Updated to work with TS v3

@pat pat merged commit 0e3fcd2 into pat:master Jan 7, 2014

@pat

This comment has been minimized.

Show comment Hide comment
@pat

pat Jan 7, 2014

Owner

Fair enough. You've got commit rights, and I guess if anyone raises issues, you or I will deal with it when we can. I certainly won't presume the gem is now managed only by you.

Owner

pat commented Jan 7, 2014

Fair enough. You've got commit rights, and I guess if anyone raises issues, you or I will deal with it when we can. I certainly won't presume the gem is now managed only by you.

@weetu

This comment has been minimized.

Show comment Hide comment
@weetu

weetu Jan 10, 2014

Collaborator

I guess the documentation should be updated too. Unless you have an urge to do that, I'll try to write some updated docs during the weekend.

Collaborator

weetu commented Jan 10, 2014

I guess the documentation should be updated too. Unless you have an urge to do that, I'll try to write some updated docs during the weekend.

@pat

This comment has been minimized.

Show comment Hide comment
@pat

pat Jan 10, 2014

Owner

If you've got the time and inclination, you're certainly welcome to :) My weekend's pretty busy, so it's unlikely I'll get to it.

Owner

pat commented Jan 10, 2014

If you've got the time and inclination, you're certainly welcome to :) My weekend's pretty busy, so it's unlikely I'll get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment