Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Don't delete delta options while reading them #13

Merged
merged 1 commit into from

2 participants

@cmaion

ThinkingSphinx 3.1 seems to instantiate the delta processor twice when generating the sphinx configuration (e.g., during rake ts:rebuild).

This patch is required to have a custom threshold value properly used during configuration generation.

@pat pat merged commit dc58825 into pat:master
@pat
Owner

Looks good, thanks :)

@cmaion

Great, thanks Pat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 7, 2014
  1. @cmaion
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/thinking_sphinx/deltas/datetime_delta.rb
View
4 lib/thinking_sphinx/deltas/datetime_delta.rb
@@ -51,8 +51,8 @@ def initialize(arg, options = {})
else # Thinking Sphinx v3
@adapter = arg
end
- @column = options.delete(:column) || :updated_at
- @threshold = options.delete(:threshold) || 1.day
+ @column = options[:column] || :updated_at
+ @threshold = options[:threshold] || 1.day
end
# Does absolutely nothing, beyond returning true. Thinking Sphinx expects
Something went wrong with that request. Please try again.