From c811def23c5f563a92878cccf0d145a6b279a490 Mon Sep 17 00:00:00 2001 From: Lovisa Svallingson Date: Mon, 21 Sep 2020 15:33:49 -0600 Subject: [PATCH 1/3] Build ruby gem before running tests --- .github/workflows/test.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8fab58b..5f1b90b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,6 +21,9 @@ jobs: - name: Install Ruby Dependencies run: bundle install + - name: Build Gem + run: gem build -o patch_ruby.gem patch_ruby.gemspec + - name: Run RSpec env: PATCH_RUBY_API_KEY: ${{ secrets.SANDBOX_API_KEY }} From 393f8f901bcb6a382f5fdd18fa17473f2fa98f69 Mon Sep 17 00:00:00 2001 From: Lovisa Svallingson Date: Mon, 21 Sep 2020 15:36:45 -0600 Subject: [PATCH 2/3] Run the specs before publishing the release --- .github/workflows/publish.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index f5caad2..4ac136e 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -19,6 +19,11 @@ jobs: - name: Build Gem run: gem build -o patch_ruby.gem patch_ruby.gemspec + - name: Run RSpec + env: + PATCH_RUBY_API_KEY: ${{ secrets.SANDBOX_API_KEY }} + run: bundle exec rspec + - name: Push to RubyGems env: GEM_HOST_API_KEY: ${{ secrets.GEM_HOST_API_KEY }} From 8e53498f23dde42c4b7cdefa2b7ffcd5dc447c3d Mon Sep 17 00:00:00 2001 From: Lovisa Svallingson Date: Mon, 21 Sep 2020 15:52:20 -0600 Subject: [PATCH 3/3] Add PR template --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..6785041 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,12 @@ +### What + +** CHANGEME: What are you changing? ** + +### Why + +** CHANGEME: Why are these changes needed? ** + +### SDK Release Checklist + +- [ ] Have you added an integration test for the changes? +- [ ] Have you built the gem locally and made queries against it successfully?