1010 setting the ld_library_path on linux systems #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dzejkop
changed the title
genail
approved these changes
Jul 25, 2018
witcher112
reviewed
Jul 25, 2018
| string launchScriptPath = LaunchScriptPath(buildPath); | ||
| string launchScriptContent = File.ReadAllText(LaunchScriptContentFile); | ||
|
|
||
| File.WriteAllText(launchScriptPath, launchScriptContent); |
Contributor
There was a problem hiding this comment.
Why not just copy the file?
| Target = "sh", | ||
| Arguments = new Manifest.Argument[] { | ||
| new Manifest.Argument { Value = new string[] { | ||
| "{exedir}" + launchScript |
Contributor
There was a problem hiding this comment.
Are you sure that {exedir} ends with slash?
| patcherExe, | ||
| "{secret}", | ||
| "{installdir}" | ||
| }}, |
Contributor
There was a problem hiding this comment.
Why there are four arguments bundled in one structure?
Contributor
Author
There was a problem hiding this comment.
The first argument:
"{exedir}" + launchScript is the shell script itself, I figured it'd be fitting to put it in a separate structure.
These four arguments are the required script arguments.
And below that there's also the optional lockfile argument.
It's basically a stylistic choice
Contributor
There was a problem hiding this comment.
Ok, if it works then it's all right.
witcher112
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.