Skip to content

Bugfix/v3.10.x/1058 added read write timeout to patchkit network #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
genail merged 4 commits into from
Sep 11, 2018
Merged

Bugfix/v3.10.x/1058 added read write timeout to patchkit network #87

genail merged 4 commits into from
Sep 11, 2018

Conversation

@Dzejkop
Copy link
Contributor

@Dzejkop Dzejkop commented Sep 10, 2018

No description provided.

@Dzejkop Dzejkop self-assigned this Sep 10, 2018
@Dzejkop Dzejkop mentioned this pull request Sep 10, 2018
Closed
genail
genail requested changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@genail genail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry in changelog

witcher112
witcher112 reviewed Sep 10, 2018
View reviewed changes
Copy link
Contributor

@witcher112 witcher112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide some resources/articles, how this will fix the issue?

@Dzejkop
Copy link
Contributor Author

Dzejkop commented Sep 11, 2018

@witcher112 according to MSDN

"Specifically, the ReadWriteTimeout property controls the time-out for the Read method, which is used to read the stream returned by the GetResponseStream method"

@witcher112
Copy link
Contributor

witcher112 commented Sep 11, 2018

The default value is 300,000 milliseconds (5 minutes).

As I can see, we are setting it for less. Are you sure it is fixing our issue?

@Dzejkop
Copy link
Contributor Author

Dzejkop commented Sep 11, 2018

It's partially fixing the issue. With this fix the Patcher won't freeze for 5 minutes, instead it'll crash the download and (hopefully) retry.

@genail
Copy link
Contributor

genail commented Sep 11, 2018

@Dzejkop did you test it with the script that I've provided?

@witcher112
Copy link
Contributor

witcher112 commented Sep 11, 2018

Never mind, it was my fault of wrong understanding of this issue. The fix is all right.

@Dzejkop
Copy link
Contributor Author

Dzejkop commented Sep 11, 2018

@genail yes I did to the extent of the download timing out and nothing more

@genail
Copy link
Contributor

genail commented Sep 11, 2018

@Dzejkop just a changelog and we can proceed.

@genail genail merged commit 2e33526 into dev/v3.10.x Sep 11, 2018
@genail genail deleted the bugfix/v3.10.x/1058-added-ReadWriteTimeout-to-patchkit-network branch September 11, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genail genail genail requested changes

@witcher112 witcher112 witcher112 approved these changes

Assignees

@Dzejkop Dzejkop

Labels

bug v3.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dzejkop @witcher112 @genail