Permalink
Switch branches/tags
Nothing to show
Commits on Jul 17, 2012
  1. Fix static analyzer warnings

    Mallory Paine committed Jul 17, 2012
Commits on Nov 19, 2011
  1. Update sample app to show how to handle dialog request results

    Christine Abernathy committed with Christine Abernathy Nov 11, 2011
    Summary:
    Part of the discussion of the abandoned diff https://phabricator.fb.com/D342789
    was that we should update the Hackbook iOS sample app to show developers how to
    process data passed back from the dialog. Changes were made to use
    dialogCompleteWithUrl: instead of
     dialogDidComplete: method. Other tweaks made to display a success message back
    to the user when an app request was sent. Also NSLog the post_id and request_ids
    information so developer can check these out.
    
    Changes still need to be made to the iOS SDK docs
    (https://developers.facebook.com/docs/reference/iossdk/FBDialogDelegate/) to let
    developers know how to handle the dialog data in the callback.
    
    Test Plan:
    1/ On iOS simulator 4.3 ran through the Publish Feed and Send Request flows.
    Checked it works and shows the proper user messages and debug messages (that
    developers could use in the future).
    2/ Tested on iPhone 5.0 and tested feed and app request dialog flows.
    
    Reviewers: brent
    
    Reviewed By: brent
    
    CC: lshepard, yariv, brent, caabernathy
    
    Differential Revision: 360490
    
    Revert Plan: OK
    
    Task ID: 697899
Commits on Nov 3, 2011
  1. Properly initialize FBDialog and Hackbook sample app data

    Christine Abernathy committed Nov 3, 2011
    Summary:
    Related to pull requests
    facebook#405
    facebook#407
    
    Test Plan:
    1/ Tested Hackbook iOS app with iPhone 4 device with iOS 5, ran through various
    screens and tested dialog.
    2/ Tested Hackbook iOS app with iPad 2 device with iOS 4.3, ran through various
    screens and tested dialog.
    
    Reviewers: yariv, brent
    
    Reviewed By: yariv
    
    CC: lshepard, yariv
    
    Differential Revision: 355088
    
    Revert Plan: OK
    
    Task ID: 786690
Commits on Nov 2, 2011
  1. Fix semantic warnings in iOS5 and Xcode 4.2

    ma11hew28 committed with Christine Abernathy Oct 13, 2011
    Summary: Pulled from facebook#401
    
    Test Plan:
    1/ Ran on iPhone 4 device with iOS 5, Hackbook iOS app, launched feed dialog,
    rotate all orientations and check works as expected. Also rotated device before
    launching dialog and rotating dialog to see it performed well.
    2/ Ran experiment (1) with iPhone 4.3 simulator.
    3/ Ran experiment (1) with iPad 4.3 simulator.
    4/ Ran experiment (1) with iPad 5.0 simulator.
    
    Reviewers: yariv, brent
    
    Reviewed By: yariv
    
    CC: lshepard, yariv
    
    Differential Revision: 354600
    
    Revert Plan: OK
    
    Task ID: 673148
Commits on Oct 13, 2011
  1. Removing old sample DemoApp.

    Christine Abernathy committed Oct 13, 2011
  2. Handle no friend case for publishing to friend's wall. Small memory l…

    Christine Abernathy committed Oct 13, 2011
    …eak fix, need to release before making savedAPIResult nil first.
  3. Update ignore file, delete files that should be ignored. Fix warning …

    Christine Abernathy committed Oct 13, 2011
    …in UITableViewCell selectionStyle assignment
Commits on Oct 10, 2011
  1. README tweaks

    Christine Abernathy committed Oct 10, 2011
  2. Merge branch 'master' of https://github.com/facebook/facebook-ios-sdk

    Christine Abernathy committed Oct 10, 2011
  3. Move the URL scheme suffix parameter from authorize: to init:

    Yariv Sadan committed Sep 29, 2011
    Summary: Moving the url scheme suffix parameter from authorize: to init:, where
    it fits better, as it behaves in a similar way to appId.
    
    Test Plan: Modified the demo app to use the new method signatures. Verified SSO
    still worked with and without a url scheme suffix.
    
    Reviewers: lshepard, brent, caabernathy, teck
    
    Reviewed By: brent
    
    CC: brent
    
    Differential Revision: 335813
  4. Dialog UI improvements, updated README, new sample Hackbook app

    Christine Abernathy committed Oct 10, 2011
Commits on Sep 28, 2011
  1. rename localAppId to urlSchemeSuffix

    Yariv Sadan committed Sep 28, 2011
    Summary: urlSchemeSuffix is more descriptive and easier to grok than
    localAppId.
    
    Warning: This changes breaks compatibility with the previous version of the SDK. Please update your code to use the latest method signature.
    
    Test Plan: compiled and ran the demo app with a urlSchemeSuffix configured
    
    Reviewers: brent, lshepard, teck
    
    Reviewed By: lshepard
    
    CC: brent, lshepard
    
    Differential Revision: 334704
    
    Task ID: 737701
Commits on Sep 23, 2011
  1. fix project file

    Michal Kijewsi committed Sep 23, 2011
Commits on Sep 13, 2011
  1. This reverts commit 74ae952.

    Yariv Sadan committed Sep 13, 2011
    The original behavior is the correct behavior as it prevents random errors from popping up the inline login dialog.
Commits on Sep 10, 2011
  1. Merge pull request #382 from FunkeeMonk/inline_fallback

    lshepard committed Sep 10, 2011
    Fallback to inline authentication dialog if SSO login fails.
Commits on Sep 9, 2011
  1. Unless the server indicates a "service_disabled_use_browser" error, f…

    FunkeeMonk committed Sep 9, 2011
    …allback to the inline authentication dialog in -[Facebook handleOpenURL:]
Commits on Aug 29, 2011
  1. Remove auth.expireSession call from SDK

    lshepard committed Aug 29, 2011
    Summary: The expireSession call was put in as a precaution to make sure that
    apps sessions were really no longer good. However, this is unnecessary and it
    causes issues with apps that were expecting the session to remain usable even
    after the user logged out. So let's remove this call and leave it up to the app
    developer to expire the session if they want.
    
    Test Plan: Logged in and out of the demo app.
    
    Reviewed By: trvish
Commits on Aug 26, 2011
  1. README changes only - Documentation update to match init session dele…

    Christine Abernathy committed Aug 26, 2011
    …gate changes. Add notice on issue reporting.
Commits on Aug 15, 2011
  1. Refactor to init session delegate in Facebook.m constructor

    raghuc committed Aug 4, 2011
    Summary: The change basically just sets the session delegate in the constructor so
    it's available when handleOpenUrl is called.
    
    Test Plan: Ran the DemoApp and ensured SSO still works.
    
    Reviewed By: toddkrabach
    
    Reviewers: seshadri, leon, atishm, toddkrabach, lshepard, caabernathy
    
    Differential Revision: 297414
    Task ID: 653835
Commits on May 27, 2011
  1. Use the Graph API for the photo uploading example.

    seshness committed May 26, 2011
    Summary:
    Edited uploadPhoto to use requestWithGraphPath instead of the legacy REST api
    requestWithMethodName method. Also added the publish_stream permission, which
    is
    needed for uploading photos.
    
    Test Plan:
    Run the DemoApp and login. Click the upload button and verify that a photo was
    uploaded to the user's Facebook account (pending approval).
    
    Reviewed By: yariv
    Reviewers: yariv
    CC: yariv
    Differential Revision: 257551
Commits on May 17, 2011
  1. a couple of small cleanups

    Yariv Sadan committed May 17, 2011
  2. small comment fix

    Yariv Sadan committed May 17, 2011
  3. Add the 'localAppId' param to [Facebook authorize]

    Yariv Sadan committed Feb 10, 2011
    Summary:
    This is the SDK diff to support the local_client_id URL parameter that we added
    to the FB app. I named it 'localAppId' to be consistent with the 'appId'
    parameter to the same function.
    
    Test Plan:
    bound the demo app to 'fb1234foo' and passed 'foo' as the localAppId value.
    verified the SDK used the 'fbauth2' url scheme to open the fb app and that the
    fb app successfully redirected back to the demo app.
    
    Reviewed By: brent
    Reviewers: lshepard, atishm, brent, oyamauchi, jimbru
    CC: brent
    Differential Revision: 211201
Commits on Apr 6, 2011
Commits on Jan 31, 2011
  1. Return FBRequest* from request: methods.

    Jim Brusstar committed Jan 31, 2011
    The request: selectors in the Facebook class now return a pointer to the
    instantiated FBRequest object (rather than void). This makes it easier
    to know in the delegate callback which request the callback maps to.
Commits on Dec 14, 2010
  1. fixing docs link

    bgold committed Dec 14, 2010
Commits on Dec 8, 2010
  1. Updates to README for platform dialogs.

    Jim Brusstar committed Dec 8, 2010
  2. Add app_id to dialog requests.

    Jim Brusstar committed Dec 8, 2010
    Updated the dialog() method to always include app_id. This will prevent
    an error if a dialog is requested and the application doesn't have an
    access token. App_id must now be specified in the Facebook constructor
    as this saves specifying it with every request. Xcode project has been
    updated to build with iOS SDK 4.3.
Commits on Dec 2, 2010
  1. Platform Dialogs Support (UIServer Pretty URLs)

    Jim Brusstar committed Nov 17, 2010
Commits on Dec 1, 2010
  1. added an anchor to dialogs

    bgold committed Dec 1, 2010
Commits on Nov 30, 2010
  1. Prevent dismissWithSuccess:animated from being called twice

    Yariv Sadan committed with Yariv Sadan Nov 30, 2010
    Summary:
    see https://github.com/facebook/facebook-ios-sdk/issues#issue/161
    
    Test Plan:
    verified it was called only once
    
    DiffCamp Revision: 186903
    Reviewed By: brent
    CC: brent
    Revert Plan:
    OK
Commits on Nov 23, 2010
  1. Adding note about plist

    mvernal committed Nov 23, 2010
  2. Clarifying start instructions

    mvernal committed Nov 23, 2010
Commits on Nov 11, 2010
  1. fix the readme formatting

    Yariv Sadan committed Nov 11, 2010
Commits on Nov 9, 2010
  1. Fix the way the SDK interprets UIWebViewDelegate errors

    Yariv Sadan committed with Yariv Sadan Nov 9, 2010
    Summary:
    Currently if the facebook app encounters a UIWebViewDelegate error, it passes
    it to the sdk in the error_code parameter. The SDK should know that if this
    parameter is passed, an error occurred, which implies the user *didn't* cancel.
    This fixes it.
    
    Test Plan:
    disconnected my laptop from the internet, went through the sso flow, verified
    the sdk set userDidCancel to NO before calling [self
    fbDialogNotLogin:userDidCancel].
    
    DiffCamp Revision: 180310
    Reviewed By: brent
    CC: brent
    Revert Plan:
    OK