Skip to content

Conversation

@JoJoJoJoJoJoJo
Copy link
Contributor

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo commented Sep 13, 2025

User description

  • only triggers release when mcpm package updates
  • remove codex

PR Type

Enhancement


Description

  • Restrict semantic release to only trigger on mcpm package changes

  • Remove codex configuration and session files


Diagram Walkthrough

flowchart LR
  A["CI Workflow"] --> B["Path Filter Added"]
  B --> C["Only mcpm Changes"]
  C --> D["Semantic Release"]
  E["Codex Files"] --> F["Removed"]
Loading

File Walkthrough

Relevant files
Configuration changes
semantic-release.yml
Add path-based triggering for semantic release                     

.github/workflows/semantic-release.yml

  • Add path filters to only trigger on src/mcpm/** and pyproject.toml
    changes
  • Restrict semantic release workflow to relevant package updates
+3/-0     
Miscellaneous
config.toml
Remove codex configuration                                                             

.github/codex/home/config.toml

  • Remove codex configuration file containing model setting
+0/-1     
rollout-2025-06-30T06-58-13-60c64452-c812-4ba8-ab56-6f2e1247bdd8.jsonl
Remove codex session logs                                                               

.github/codex/home/sessions/rollout-2025-06-30T06-58-13-60c64452-c812-4ba8-ab56-6f2e1247bdd8.jsonl

  • Remove codex session log file with debugging and fix attempts
+0/-33   
codex-attempt.md
Remove codex attempt template                                                       

.github/codex/labels/codex-attempt.md

  • Remove codex attempt template file
+0/-9     
codex-review.md
Remove codex review template                                                         

.github/codex/labels/codex-review.md

  • Remove codex review template file
+0/-7     
codex-triage.md
Remove codex triage template                                                         

.github/codex/labels/codex-triage.md

  • Remove codex triage template file
+0/-7     

Summary by CodeRabbit

  • Bug Fixes

    • Improved Claude Desktop MCP integration to correctly handle optional aliases for router entries, ensuring accurate naming when adding or updating profiles via mcpm.
  • Chores

    • Removed Codex automation and related configuration/templates, disabling Codex-triggered workflows.
    • Updated Semantic Release workflow to trigger only on changes to core source files and project configuration (reduced unnecessary runs).

@coderabbitai
Copy link

coderabbitai bot commented Sep 13, 2025

Walkthrough

Removes multiple Codex-related configuration and workflow files, narrows Semantic Release triggers to specific paths, and updates Claude Desktop MCP integration to pass an optional alias through a router server formatting method.

Changes

Cohort / File(s) Summary
Codex assets removed
\.github/codex/home/config.toml, \.github/codex/labels/*, \.github/workflows/codex.yml
Deleted Codex config, label templates, and the Codex GitHub Actions workflow, disabling Codex automation and removing related docs/config.
Semantic Release trigger scoping
\.github/workflows/semantic-release.yml
Added path filters so the workflow runs on pushes to main only when src/mcpm/** or pyproject.toml change.
Claude Desktop MCP router alias handling
\.github/codex/home/sessions/rollout-2025-06-30T06-58-13-60c64452-c812-4ba8-ab56-6f2e1247bdd8.jsonl
Documents code change: ClaudeDesktopManager._format_router_server now accepts optional alias_name and forwards it to format_server_url_with_proxy_headers.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Manager as ClaudeDesktopManager
  participant Router as format_server_url_with_proxy_headers
  participant Config as ServerConfig

  User->>Manager: activate_profile(profile_name, base_url, alias_name?)
  Manager->>Manager: _format_router_server(profile_name, base_url, alias_name?)
  note right of Manager: Updated: forwards optional alias_name
  Manager->>Router: format_server_url_with_proxy_headers(client_key, profile_name, base_url, alias_name?)
  Router-->>Manager: ServerConfig
  Manager-->>User: ServerConfig
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Review effort 1/5

Poem

I tidied the burrow, swept Codex away,
Trimmed releases to paths that sway.
Added a name tag for routers to see—
alias nibble, neat as can be.
Thump-thump! said the rabbit, ears held high,
Clean hops, clear trails, under autumn sky. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix(ci): only trigger release for mcpm update" is concise, uses conventional commit style, and accurately highlights the primary change—restricting semantic-release triggers to mcpm-related updates—matching the PR objectives; it does not need to name the removed Codex artifacts because titles should focus on the main change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jonathan/ci-semantic-release

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a7b152 and 370afe3.

📒 Files selected for processing (7)
  • .github/codex/home/config.toml (0 hunks)
  • .github/codex/home/sessions/rollout-2025-06-30T06-58-13-60c64452-c812-4ba8-ab56-6f2e1247bdd8.jsonl (0 hunks)
  • .github/codex/labels/codex-attempt.md (0 hunks)
  • .github/codex/labels/codex-review.md (0 hunks)
  • .github/codex/labels/codex-triage.md (0 hunks)
  • .github/workflows/codex.yml (0 hunks)
  • .github/workflows/semantic-release.yml (1 hunks)
💤 Files with no reviewable changes (6)
  • .github/codex/labels/codex-attempt.md
  • .github/codex/labels/codex-triage.md
  • .github/workflows/codex.yml
  • .github/codex/labels/codex-review.md
  • .github/codex/home/config.toml
  • .github/codex/home/sessions/rollout-2025-06-30T06-58-13-60c64452-c812-4ba8-ab56-6f2e1247bdd8.jsonl
🔇 Additional comments (1)
.github/workflows/semantic-release.yml (1)

7-9: Path filter incorrect — update workflow paths.

Verification: pyproject.toml found at repo root; src/mcpm not found.

  • Update .github/workflows/semantic-release.yml (lines 7–9): replace 'src/mcpm/' with the actual package path (or use 'src/' to cover packages under src/).
  • Optional: also trigger on release-config changes — add '.releaserc', '.releaserc.*', '.github/semantic-release/**', '.github/workflows/semantic-release.yml'.
  • Optional: add workflow_dispatch for manual/emergency runs.

Likely an incorrect or invalid review comment.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-merge-pro
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Trigger Scope

The path filter may skip releases when only non-watched files that affect the published package change (e.g., a root README used as long_description, license, or manifest files). Confirm all files that influence the mcpm distribution are included.

paths:
  - 'src/mcpm/**'
  - 'pyproject.toml'
Overtriggering

Including pyproject.toml will trigger releases on any change to it (tooling/config tweaks unrelated to mcpm). Validate that this broader trigger matches the intended policy, or consider narrowing paths if needed.

paths:
  - 'src/mcpm/**'
  - 'pyproject.toml'

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Include additional release-relevant paths

The path filter is too restrictive and may miss important changes that should
trigger releases. Consider including additional paths like documentation
updates, configuration changes, or dependency updates that could affect the
package.

.github/workflows/semantic-release.yml [3-9]

 on:
   push:
     branches:
       - main
     paths:
       - 'src/mcpm/**'
       - 'pyproject.toml'
+      - 'CHANGELOG.md'
+      - 'README.md'
+      - 'uv.lock'

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that the new path filters might be too restrictive, and proposes adding other relevant files like uv.lock to ensure all package-affecting changes trigger a release.

Low
  • More

@JoJoJoJoJoJoJo JoJoJoJoJoJoJo merged commit c1f02a3 into main Sep 13, 2025
8 checks passed
@JoJoJoJoJoJoJo JoJoJoJoJoJoJo deleted the jonathan/ci-semantic-release branch September 13, 2025 02:47
mcpm-semantic-release bot pushed a commit that referenced this pull request Sep 13, 2025
## [2.8.1](v2.8.0...v2.8.1) (2025-09-13)

### Bug Fixes

* **ci:** only trigger release for mcpm update ([#262](#262)) ([c1f02a3](c1f02a3))
* set working directory if current is invalid ([#261](#261)) ([d54acd3](d54acd3))
@mcpm-semantic-release
Copy link

🎉 This PR is included in version 2.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants