Remove InstanceMethods deprecation warning #25

Merged
merged 1 commit into from Jul 27, 2012

Conversation

Projects
None yet
6 participants
Contributor

leereilly commented Jun 7, 2012

Removes the following:

DEPRECATION WARNING: The InstanceMethods module inside ActiveSupport::Concern will be no longer included automatically. Please define instance methods directly in NoPeepingToms instead. (called from include at /Volumes/GitHub/no-peeping-toms/spec/../lib/no_peeping_toms.rb:83)

Cheers,
Lee 🍻

@leereilly leereilly Remove InstanceMethods deprecation warning
Removes the following:

DEPRECATION WARNING: The InstanceMethods module inside ActiveSupport::Concern will be no longer included automatically. Please define instance methods directly in NoPeepingToms instead. (called from include at /Volumes/GitHub/no-peeping-toms/spec/../lib/no_peeping_toms.rb:83)
e5fbd73

+1 to this or any of the other pull requests that take care of this issue. Dont make me bundle from a fork!

jch commented Jul 26, 2012

+1 bump

dewski commented Jul 26, 2012

👍

patmaddox merged commit 02421b4 into patmaddox:master Jul 27, 2012

Owner

patmaddox commented Jul 27, 2012

thank you for this, Lee & all the other folks who have submitted a fix. Here it is

okay so the next step is to publish an updated gem

I'm unsure of how to proceed. Since Rails has incorporated this functionality, NPT is no longer necessary. I don't intend to maintain it. I will assume that with this commit, NPT can be considered "done", and if folks have a desire to maintain it and take over the rubygems ownership then they'll get in touch with me.

Hi Pat,
Just to confirm, I'm I correct in thinking that I can drop the NPT gem from my Gemfile without any modification to my app and everything will still work exactly the same because Rails now has this functionality?

Owner

patmaddox commented Jan 14, 2013

Hi Ike, I don't know enough about the Rails implementation to confirm that. My top suggestion is to give it a whirl and see what happens, followed by getting in touch with Myron Marston, who implemented this functionality in Rails.

Thanks Pat!

On Sunday, January 13, 2013, Pat Maddox wrote:

Hi Ike, I don't know enough about the Rails implementation to confirm
that. My top suggestion is to give it a whirl and see what happens,
followed by getting in touch with Myron Marston, who implemented this
functionality in Rails.


Reply to this email directly or view it on GitHubhttps://github.com/patmaddox/no-peeping-toms/pull/25#issuecomment-12204699.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment