Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for the latest pydicom #43

Closed
wants to merge 2 commits into from
Closed

Changes for the latest pydicom #43

wants to merge 2 commits into from

Conversation

naggie
Copy link
Collaborator

@naggie naggie commented Jan 15, 2016

Fixes #31 and #26

...aside from the dependent pydicom version number which has not changed yet.

As noted, cancan101@b41cfa1 may be the better fix, however a similar fix is also required for #31 .

Depends on if backwards compatibility is required or not. I would suggest not requiring it so long as pydicom releases a new version number which becomes a dependency.

@naggie
Copy link
Collaborator Author

naggie commented Jan 19, 2016

This is more of a problem than I realised -- old (pip) versions of pynetdicom don't specify pydicom as a dependency. This means deployments with virtualenv+pip fail without installing pydicom first. This is exacerbated if you need to deploy versions before and after the rename.

Perhaps @cancan101 's fix is therefore more appropriate.

@cancan101
Copy link
Contributor

I just filed an issue with pydicom to please release to pypi with new package.

In the meantime you can also try: cancan101@a65b114 (this is my new fork of this project). You will need to pip install with --process-dependency-links.

@naggie
Copy link
Collaborator Author

naggie commented Jan 19, 2016

Excellent, thanks!

@cancan101
Copy link
Contributor

This might also be helpful: pypa/pip#1274

@naggie
Copy link
Collaborator Author

naggie commented Apr 8, 2016

Looks like cancan101's PR has resolved this. Thanks

@naggie naggie closed this Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest revision broke lots of things
2 participants