Naming conflict for class 'text'

[jeroen]

The new $.text methods introduced in 0.5.0 has created a conflict with ggplot2. It seem to trigger the very unfortunately named grid:::validDetails.text.

library(corpus)
library(ggplot2)
ggplot(cars, aes(x = speed)) + geom_bar()
# Error in `$.text`(x, "label") : $ operator is invalid for text objects

Not sure if this is a bug in ggplot2 or corpus. @hadley.

[patperry]

Thanks for the heads up. This seems like a bug in ggplot2, but maybe it's best if I work around it by renaming the class to corpus_text. (p.s. this issue really belongs on https://github.com/patperry/r-corpus , not here)

[patperry]

Thanks for the heads up. This seems like a bug in ggplot2, but maybe it's best if I work around it by renaming the class to corpus_text. (p.s. this issue really belongs on https://github.com/patperry/r-corpus , not here)

[patperry]

Also, it's weird that this didn't show up before; the $.text method was there in version 0.4.0. I think the problem has to do with corpus importing Matrix, which imports grid. (Version 0.4.0 did not import or use anything from Matrix.)

[patperry]

Also, it's weird that this didn't show up before; the $.text method was there in version 0.4.0. I think the problem has to do with corpus importing Matrix, which imports grid. (Version 0.4.0 did not import or use anything from Matrix.)

[jeroen]

I think it gets triggered because you added S3method($, text) to the NAMESPACE.

[jeroen]

I think it gets triggered because you added S3method($, text) to the NAMESPACE.

[patperry]

Fixed now: patperry/r-corpus@3d9f299 . I'll submit a new version to CRAN (0.5.1).

[patperry]

Fixed now: patperry/r-corpus@3d9f299 . I'll submit a new version to CRAN (0.5.1).

[jeroen]

Maybe try running the benchmark.Rmd script before submitting.

[jeroen]

Maybe try running the benchmark.Rmd script before submitting.

[patperry]

Great suggestion. I'll make sure everything runs smoothly before I submit.

[patperry]

Great suggestion. I'll make sure everything runs smoothly before I submit.

[patperry]

Just submitted version 0.5.1 to CRAN. Benchmarks runs smoothly now (slightly faster read time, and faster manipulation times). No need for the "as.character" call in the last benchmark any more.

[patperry]

Just submitted version 0.5.1 to CRAN. Benchmarks runs smoothly now (slightly faster read time, and faster manipulation times). No need for the "as.character" call in the last benchmark any more.