Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds Sentry, FullStory, and a Makefile for releases #1

Merged
merged 2 commits into from Feb 12, 2020

Conversation

@scefali
Copy link
Collaborator

scefali commented Feb 12, 2020

This PR sets up Sentry and Fullstory along with the Sentry-Fullstory integration. It also adds Makefile which will be used for releases.

@scefali scefali requested a review from patrick-fs Feb 12, 2020
Sentry.init({
dsn: 'https://87dd10a700ea41e9a64df50ec9b367c7@sentry.io/2418505',
integrations: [ new SentryFullStory('sentry-test') ]
});

This comment has been minimized.

Copy link
@patrick-fs

patrick-fs Feb 12, 2020

Owner

Would it be a good idea to move these values into a .env file and use React env vars?

See: https://github.com/patrick-fs/fs-react-redux-sentry/blob/master/src/index.js#L12

This comment has been minimized.

Copy link
@scefali

scefali Feb 12, 2020

Author Collaborator

@patrick-fs for the purposes of the webinar, don't think so. Otherwise, you'd just have to copy the contents of my .env into yours. The calculus is a bit different if you want other people to clone your repo and run it with their own Sentry/FullStory orgs.

# Following variable must be passed in
# SENTRY_AUTH_TOKEN
SENTRY_ORG=sentry-test
SENTRY_PROJECT=fullstory-demo

This comment has been minimized.

Copy link
@patrick-fs

patrick-fs Feb 12, 2020

Owner

Maybe all of these values can be put in a .env file so they can be used by the CLI and by the Create React App as well?

This comment has been minimized.

Copy link
@scefali

scefali Feb 12, 2020

Author Collaborator

@patrick-fs That's what I would prefer but the Makefile doesn't automatically load values from the .env (but the Sentry CLI will pick the token from there for some reason). You have to write code that opens the file and loads it. I prefer keeping this simple even if I have to repeat a few lines of config.

Copy link
Owner

patrick-fs left a comment

LGTM! I added some questions particular to handling values in a .env file

@@ -0,0 +1,19 @@
# Must have `sentry-cli` installed globally

This comment has been minimized.

Copy link
@patrick-fs

patrick-fs Feb 12, 2020

Owner

nit: add a link to installation instructions: https://docs.sentry.io/cli/installation/

@scefali scefali merged commit 2674f5a into patrick-fs:develop Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.