From dcdabb75fabbaa7255644e98e2bf00166dbf1a1e Mon Sep 17 00:00:00 2001 From: Patrick Hulce Date: Wed, 23 Nov 2016 11:57:16 -0800 Subject: [PATCH] fix: identify rel noopener in list (#1035) addresses #1029 --- lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html | 2 +- .../gatherers/dobetterweb/anchors-with-no-rel-noopener.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html index 4fb0d8f0437e..546aa58e01f4 100644 --- a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html +++ b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html @@ -82,7 +82,7 @@

Do better web tester page

external link - external link that uses rel="noopener" + external link that uses rel noopener and another unrelated rel attribute internal link is ok diff --git a/lighthouse-core/gather/gatherers/dobetterweb/anchors-with-no-rel-noopener.js b/lighthouse-core/gather/gatherers/dobetterweb/anchors-with-no-rel-noopener.js index 70a26927c033..e4396e29147d 100644 --- a/lighthouse-core/gather/gatherers/dobetterweb/anchors-with-no-rel-noopener.js +++ b/lighthouse-core/gather/gatherers/dobetterweb/anchors-with-no-rel-noopener.js @@ -22,7 +22,7 @@ class AnchorsWithNoRelNoopener extends Gatherer { afterPass(options) { const driver = options.driver; - return driver.querySelectorAll('a[target="_blank"]:not([rel="noopener"])') + return driver.querySelectorAll('a[target="_blank"]:not([rel~="noopener"])') .then(failingNodeList => { const failingNodes = failingNodeList.map(node => { return Promise.all([