feat(package): add commonjs and es modules using rollup #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing these modern bundle formats should help increase library adoption. This more modular approach will allow developers to shake out unused functions using the bundler in their project as well. Note that some interface exports were made starry because of a limitation of the typescript plugin. The use of that plugin does resolve an issue with the build related to spread operator polyfilling. There should be no breaking changes since the UMD module output is still marked as main, and the name of the module hasn't changed.
patrickmichalina
approved these changes
Feb 2, 2020
Owner
patrickmichalina
left a comment
patrickmichalina
left a comment
There was a problem hiding this comment.
This is awesome, thanks for taking the time to do this!
Owner
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing these modern bundle formats should help increase library adoption. This more modular
approach will allow developers to shake out unused functions using the bundler in their project as
well. Note that some interface exports were made starry because of a limitation of the typescript
plugin. The use of that plugin does resolve an issue with the build related to spread operator
polyfilling (for cjs bundles, anyway). There should be no breaking changes since the UMD module output is still marked as
main, and the name of the module hasn't changed.