New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture.cpp: use COLOR_BGR2BGRA instead of CV_BGR2BGRA #40

Open
waqarsqureshi opened this Issue Apr 21, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@waqarsqureshi
Copy link

waqarsqureshi commented Apr 21, 2018

I was compiling 4dface and figured out that while compiling if you change to COLOR_BGR2BGRA, we can compile using latest version of opencv.

best

@patrikhuber

This comment has been minimized.

Copy link
Owner

patrikhuber commented Apr 22, 2018

Thank you for the report!
Indeed I think you're right - I will include this the next time I'm going to push changes.

Thanks again :)

@waqarsqureshi

This comment has been minimized.

Copy link
Author

waqarsqureshi commented Apr 22, 2018

Lets close the issue then?

@patrikhuber

This comment has been minimized.

Copy link
Owner

patrikhuber commented Apr 22, 2018

Let's leave this open to track it, since there is no PR at the moment.

@patrikhuber patrikhuber reopened this Apr 22, 2018

@valbi

This comment has been minimized.

Copy link

valbi commented May 23, 2018

Hello,
My opencv version is the 4.0.0 and I had the same issue when I run "make" after cmake of source.
So I replaced CV_BGR2BGRA by 0 but I've got 3 others errors :

CMakeFiles/4dface.dir/apps/4dface.cpp.o  : In function « cv::Mat::Mat(int, int, int, void*, unsigned long) [clone .constprop.5619] » : 4dface.cpp:(.text+0x6318) : undefined reference to « cv::Mat::updateContinuityFlag() »
CMakeFiles/4dface.dir/apps/4dface.cpp.o : In function « rcr::HogTransform::operator()(cv::Mat, unsigned long, int) » : 4dface.cpp (.text._ZN3rcr12HogTransformclEN2cv3MatEmi[ZN3rcr12HogTransformclEN2cv3MatEmi]+0xf9e) : undefined reference to « cv::Mat::updateContinuityFlag() »
CMakeFiles/4dface.dir/apps/4dface.cpp.o : Dans la fonction « main » :
4dface.cpp:(.text.startup+0x14bb) : undefined reference to « cv::rectangle(cv::InputOutputArray const&, cv::Rect, cv::Scalar
const&, int, int, int) »

However, cv::Mat::updateContinuityFlag() is still in the current version of opencv https://docs.opencv.org/master/d3/d63/classcv_1_1Mat.html and idem for rectangle https://docs.opencv.org/master/d6/d6e/group__imgproc__draw.html#gac865734d137287c0afb7682ff7b3db23

@waqarsqureshi

This comment has been minimized.

Copy link
Author

waqarsqureshi commented May 23, 2018

Perhaps you need to compile opencv again! This only means that the function is not found in the library you compiled. Do you have two version of opencv installed?

@patrikhuber

This comment has been minimized.

Copy link
Owner

patrikhuber commented May 23, 2018

@valbi Hi,
I don't think this source code is using cv::Mat::updateContinuityFlag() anywhere, I haven't seen that function before. I think you're just not linking OpenCV correctly or have some problem locally. Shouldn't have anything to do with the 4dface code.

@valbi

This comment has been minimized.

Copy link

valbi commented May 24, 2018

Ok, 4dface works.
After re-compile opencv4, i've got the error about OpenCV_haarcascades_DIR, like in the Build & run readme of 4dface. I never have this error at the first cmake, so opencv was not well compiled
I think when i follow build directions, i execute sudo apt-get install gcc-7 g++-7 libboost-all-dev libeigen3-dev libopencv-dev opencv-data with opencv already build and install from git source code. I should have removed libopencv-dev and opencv-data.
Thank you @waqarsqureshi and @patrikhuber.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment