Add error unimplemented - #51
Merged
Merged
Conversation
Owner
|
Originally the "unimplemented error" prompted the user to submit a bug report, but that was some time ago |
Contributor
Author
Ok should I rename it to |
Owner
|
Perhaps change the message to "Unimplemented element. Consider reporting
via https://github.com/patsplat/plist/issues"
Thanks for submitting the PR, it looks good.
…On Sat, Oct 5, 2019 at 12:27 PM Laurent Arnoud ***@***.***> wrote:
Originally the "unimplemented error" prompted the user to submit a bug
report, but that was some time ago
Ok should I rename it to ElementNotFound for example ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#51?email_source=notifications&email_token=AABLTQV2CGVM7XQ7V2FBOBDQNC57NA5CNFSM4IX4ICZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANWAWI#issuecomment-538665049>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABLTQU4BYZMEF5XDKEJUB3QNC57NANCNFSM4IX4ICZQ>
.
--
*Patrick Way*
Senior Engineering Manager
T: 347 232-5208
patrick.way@intersection.com
*Intersection*
10 Hudson Yards, Intersection 26 Floor, NY NY 10001
intersection.com
|
Contributor
Author
|
Thanks its updated o/ |
patsplat
approved these changes
Dec 29, 2019
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 14, 2021
3.6.0 (2020-12-30) New features and important changes: * Do not indent multiline string values (github.com/patsplat/plist/pull/54) * Add `Plist::UnimplementedElementError` (github.com/patsplat/plist/pull/51) * Add support for text inside `<![CDATA[ … ]]>` (github.com/patsplat/plist/pull/49) Housekeeping: * Add Ruby 2.7 and 3.0 to CI (github.com/patsplat/plist/pull/55) * add docker-compose for development (github.com/patsplat/plist/pull/47) * Replace `require` with `require_relative`(github.com/patsplat/plist/pull/52)
msk
pushed a commit
to msk/pkgsrc
that referenced
this pull request
May 11, 2026
3.6.0 (2020-12-30) New features and important changes: * Do not indent multiline string values (github.com/patsplat/plist/pull/54) * Add `Plist::UnimplementedElementError` (github.com/patsplat/plist/pull/51) * Add support for text inside `<![CDATA[ … ]]>` (github.com/patsplat/plist/pull/49) Housekeeping: * Add Ruby 2.7 and 3.0 to CI (github.com/patsplat/plist/pull/55) * add docker-compose for development (github.com/patsplat/plist/pull/47) * Replace `require` with `require_relative`(github.com/patsplat/plist/pull/52)
jperkin
pushed a commit
to TritonDataCenter/pkgsrc
that referenced
this pull request
May 14, 2026
3.6.0 (2020-12-30) New features and important changes: * Do not indent multiline string values (github.com/patsplat/plist/pull/54) * Add `Plist::UnimplementedElementError` (github.com/patsplat/plist/pull/51) * Add support for text inside `<![CDATA[ … ]]>` (github.com/patsplat/plist/pull/49) Housekeeping: * Add Ruby 2.7 and 3.0 to CI (github.com/patsplat/plist/pull/55) * add docker-compose for development (github.com/patsplat/plist/pull/47) * Replace `require` with `require_relative`(github.com/patsplat/plist/pull/52)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this add UnimplementedElementError when an element is not found the plist, cheers