Skip to content
This repository was archived by the owner on Dec 10, 2019. It is now read-only.

Fix missing pattern handling #2

Merged
merged 4 commits into from
Oct 12, 2016
Merged

Conversation

geoffp
Copy link
Contributor

@geoffp geoffp commented Oct 12, 2016

Summary of changes:

  • if a requested pattern partial is missing, say so; if there's compilation error, print the output from the exception.
  • if you've tried to call a non-existent pattern with _.renderNamedPartial('atom-not-there', obj), say so in the error message
  • beautiful and helpful error reporting during underscore template rendering
  • Shift template compilation time to the partial registration phase

@geoffp geoffp self-assigned this Oct 12, 2016
@geoffp geoffp merged commit 863d637 into master Oct 12, 2016
@geoffp geoffp deleted the fix-missing-pattern-handling branch October 12, 2016 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant