From 613bba104f2082be507938db78f1db7a07f6b8be Mon Sep 17 00:00:00 2001 From: Salem Ghoweri Date: Fri, 22 Nov 2019 06:55:24 -0500 Subject: [PATCH 1/2] fix: testing potential FF fix for https://github.com/pattern-lab/patternlab-node/issues/1100 --- packages/uikit-workshop/src/sass/pattern-lab.scss | 3 +-- packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/uikit-workshop/src/sass/pattern-lab.scss b/packages/uikit-workshop/src/sass/pattern-lab.scss index 93b6c9613..f13f02cc7 100755 --- a/packages/uikit-workshop/src/sass/pattern-lab.scss +++ b/packages/uikit-workshop/src/sass/pattern-lab.scss @@ -65,8 +65,7 @@ @supports (position: sticky){ transform: translateY(-0.7rem); float: right; - position: sticky; - top: 1rem; + top: 3.2rem; right: 0; margin-top: -2rem; } diff --git a/packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss b/packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss index 636c35567..4867f48f0 100644 --- a/packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss +++ b/packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss @@ -93,6 +93,7 @@ flex-basis: auto; -webkit-overflow-scrolling: touch; height: 100%; + overflow: auto; // workaround to firefox background gradient overflow bug /** * Tab content inside modal From 378cf4282a3e5b4f597287eb538270e3358c8c69 Mon Sep 17 00:00:00 2001 From: Salem Ghoweri Date: Fri, 22 Nov 2019 07:52:19 -0500 Subject: [PATCH 2/2] fix: simplify overflow fix --- packages/uikit-workshop/src/sass/pattern-lab.scss | 11 +---------- .../src/sass/scss/04-components/_tabs.scss | 3 +-- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/packages/uikit-workshop/src/sass/pattern-lab.scss b/packages/uikit-workshop/src/sass/pattern-lab.scss index f13f02cc7..f9b096cdc 100755 --- a/packages/uikit-workshop/src/sass/pattern-lab.scss +++ b/packages/uikit-workshop/src/sass/pattern-lab.scss @@ -59,17 +59,8 @@ .pl-c-code-copy-btn { display: inline-block; position: absolute; - top: 0.5rem; + top: 0.4rem; right: 0.5rem; - - @supports (position: sticky){ - transform: translateY(-0.7rem); - float: right; - top: 3.2rem; - right: 0; - margin-top: -2rem; - } - padding: 0.2rem 0.4rem; background-color: $pl-color-gray-07; color: $pl-color-gray-87; diff --git a/packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss b/packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss index 4867f48f0..8557c60e1 100644 --- a/packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss +++ b/packages/uikit-workshop/src/sass/scss/04-components/_tabs.scss @@ -92,8 +92,7 @@ display: flex; flex-basis: auto; -webkit-overflow-scrolling: touch; - height: 100%; - overflow: auto; // workaround to firefox background gradient overflow bug + overflow-y: auto; // workaround to firefox background gradient overflow bug /** * Tab content inside modal