Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uikitworkshop): absolutely positioned pattern parts at the vertical end of the "page" would get cropped #1174

Closed
mfranzke opened this issue Apr 30, 2020 · 0 comments · Fixed by #1175
Closed

fix(uikitworkshop): absolutely positioned pattern parts at the vertical end of the "page" would get cropped #1174

mfranzke opened this issue Apr 30, 2020 · 0 comments · Fixed by #1175

Comments

@mfranzke
Copy link
Contributor

mfranzke commented Apr 30, 2020 •
edited
Loading

Due to the following CSS declaration, absolutely positioned pattern parts at the end of the "page" would get cropped:

patternlab-node/packages/uikit-workshop/src/sass/pattern-lab.scss

Line 109 in 123427a

overflow: hidden;

The scroll position doesn't need to be at the end of the viewport; it's mainly related to that the container additionally wouldn't extend to the viewports height, but as well to the initial aspect of cropping absolutely positioned elements on the vertical.

Compare to:
image

Expected display:
image

I've been able to rebuild a simplified example here: https://output.jsbin.com/munabac/1
Only the first item within the "collapsing menu" (after pressing the interaction element "Toggle Overflow menu") is visible within the second pattern.
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Apr 30, 2020
fix(uikitworkshop): preventing cropping pattern parts pattern-lab#1174
6a67d03 
absolutely positioned pattern parts at the vertical end of the "page" would get cropped elsewhere
@mfranzke mfranzke mentioned this issue Apr 30, 2020
Merged
sghoweri added a commit that referenced this issue May 9, 2020
@sghoweri
Merge pull request #1175 from mfranzke/fix-uikitworkshop-absolutely-p…
3d2aaf7 
…ositioned-pattern-parts-at-the-vertical-end-of-the-page-would-get-cropped

fix(uikitworkshop): preventing cropping pattern parts #1174
@mfranzke mfranzke mentioned this issue Jun 3, 2020
Closed
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
fix(uikitworkshop): preventing cropping pattern parts pattern-lab#1174
a035f50 
absolutely positioned pattern parts at the vertical end of the "page" would get cropped elsewhere
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
@sghoweri
Merge pull request pattern-lab#1175 from mfranzke/fix-uikitworkshop-a…
abeed3d 
…bsolutely-positioned-pattern-parts-at-the-vertical-end-of-the-page-would-get-cropped

fix(uikitworkshop): preventing cropping pattern parts pattern-lab#1174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(uikitworkshop): preventing cropping pattern parts #1174 mfranzke/patternlab-node
1 participant
@mfranzke