Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe namechange pattern_assembler.findPartial to pattern_assembler.getPartial #407

Closed
e2tha-e opened this issue Jul 27, 2016 · 3 comments
Closed

Comments

@e2tha-e
Copy link
Contributor

e2tha-e commented Jul 27, 2016

The public pattern_assembler function is named findPartial while the private function is named getPartial. This results in a couple points of confusion. The first is trying to figure out the rationale for this difference. The second is that findPartial is an engine_mustache public function, which performs a completely different operation. I think in pattern_assembler, it should be named getPartial.

@bmuenzenmeyer
Copy link
Member

I have had the same thought a couple times - especially as the codebase has evolved and engines have a similar method.

👍

stevemartin pushed a commit to stevemartin/patternlab-node that referenced this issue Aug 8, 2016
* pattern_assembler.findPartial to pattern_assembler.getPartial
@e2tha-e e2tha-e closed this as completed Aug 11, 2016
@bmuenzenmeyer
Copy link
Member

@e2tha-e just so you know my crazy methods, i typically leave issues open until they reach master

@e2tha-e
Copy link
Contributor Author

e2tha-e commented Aug 15, 2016

@bmuenzenmeyer Oops. Sorry. Will keep mind next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants