New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading state guidance to the Table View #469

Closed
serenamarie125 opened this Issue Oct 26, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@serenamarie125
Member

serenamarie125 commented Oct 26, 2017

This is an enhancement to an existing pattern to add a loading state note to the table view.

When there are performance issues, users have to wait for the view to load. We should give guidance around using a loading state ( which would likely be a Large Spinner control with the "Loading" text below it).

Note that on the design page of this pattern, we are already giving guidance around if the view is empty http://www.patternfly.org/pattern-library/content-views/table-view/#/design.

@mcarrano @maryclarke @catrobson do you support this suggestion?

Associated Issues:
#468
#467

@catrobson

This comment has been minimized.

Member

catrobson commented Oct 26, 2017

@serenamarie125 Agree for first load. In some of our implementations, we're also seeing lazy load taking time, and in this case I think clearing out the table doesn't make sense. Do you think a lazy load solution for spinners is another separate issue/contribution?

@mcarrano mcarrano added this to New / Needs Info in PatternFly Contributions Oct 26, 2017

@mcarrano mcarrano moved this from New / Needs Info to Accepted-In Progress in PatternFly Contributions Oct 26, 2017

@mcarrano

This comment has been minimized.

Member

mcarrano commented Nov 2, 2017

@serenamarie125 is there someone assigned to work on this? (and also #467)

@mcarrano mcarrano moved this from Detailed Design & Document to Accepted-ToDo/Backlog in PatternFly Contributions Dec 15, 2017

@serenamarie125

This comment has been minimized.

Member

serenamarie125 commented Feb 13, 2018

@mcarrano the proposed design is to use the same solutions we give for the base card. Display a Large Spinner control with the "Loading" text below it. Loading would be the default text ( with no ellipses ), but should be customizable from an implementation perspective.

Note that this suggestion is consistent with the loading state of the card shown here: http://www.patternfly.org/pattern-library/cards/base-card/#design

@mcarrano mcarrano removed the Help Wanted label Feb 14, 2018

@terezanovotna terezanovotna referenced this issue Feb 21, 2018

Merged

Adding new loading pattern #574

6 of 6 tasks complete

@mcarrano mcarrano removed this from Accepted-ToDo/Backlog in PatternFly Contributions Feb 22, 2018

@mcarrano mcarrano closed this Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment