New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document guidelines for using tabs #526

Closed
mcarrano opened this Issue Jan 16, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@mcarrano
Member

mcarrano commented Jan 16, 2018

For Pattern contribution proposal, tell us about your idea...

(delete section if filing a bug)

1. Choose the type of contribution for this pattern:

  • This is a new pattern
  • This is an enhancement on an existing pattern

We currently support two different tab styles in PatternFly that can be applied separately or in combination. See https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/tabs.html for examples. Beyond these examples we have no guidance on when and how designers should apply these tabs in designs. This issue proposes to create a new pattern that documents usage guidelines to go along with these examples.

A new pattern should be added under Forms and Controls.

@mcarrano mcarrano changed the title from Create new pattern with guidelines for using tabs to Document guidelines for using tabs Jan 16, 2018

@mcarrano

This comment has been minimized.

Member

mcarrano commented Jan 16, 2018

Note that we currently support including a dropdown menu within a tab. It's not clear what the use case is for this other than collapsing the tab bar into a dropdown when the window width is decreased. Is this pattern currently being used in existing applications? Consider whether this pattern is needed as part of generating these guidelines.

@mcarrano mcarrano added this to New / Needs Info in PatternFly Contributions Jan 18, 2018

@mcarrano mcarrano moved this from New / Needs Info to Accepted-ToDo/Backlog in PatternFly Contributions Jan 18, 2018

@serenamarie125

This comment has been minimized.

Member

serenamarie125 commented Jan 21, 2018

@mcarrano I think it was used in Satellite when they were using Horizontal nav - @Rohoover is that the case?

@Rohoover

This comment has been minimized.

Member

Rohoover commented Jan 22, 2018

@serenamarie125

I don't recall them in the horizontal nav, but in the content pages themselves. See screenshot from the Content Hosts details page:

screen shot 2018-01-22 at 9 31 11 am

@mcarrano mcarrano referenced this issue Apr 18, 2018

Closed

Tabs #30

4 of 6 tasks complete

@mcarrano mcarrano added PatternFly-4 and removed Help Wanted labels Apr 24, 2018

@mcarrano

This comment has been minimized.

Member

mcarrano commented Apr 24, 2018

I am going to close this out for now but I think it is something that we should consider as we are creating documentation for PatternFly Next

@mcarrano mcarrano closed this Apr 24, 2018

@mcarrano mcarrano removed this from Backlog in PatternFly Contributions Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment