New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): internals controller improvements #2296
feat(core): internals controller improvements #2296
Conversation
🦋 Changeset detectedLatest commit: e378556 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
853b619
to
9da29e8
Compare
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
17e7e93
to
5fe3ff7
Compare
9b968bb
to
28176a6
Compare
|
when the fieldset is disabled but the button is not disabled, user is able to tab to the button, although it renders in grey. thanks for the report, @brianferry |
|
I toyed around with some ways to hook into the form callbacks from the controller, but none were particularly satisfying, so let's do all that on the button class instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What I did
roleandaria*props inElementInternalstoInternalsControllerform*Callbackmethods inInternalsControllerformDisabled: booleantoInternalsControllerTesting Instructions
Check out button's
form controlsdemo and make sure everything's kosher there