Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: band padding & node engine increment in package.json #2297

Merged
merged 3 commits into from Jan 3, 2023

Conversation

brianferry
Copy link
Collaborator

  1. Changed the engines included in the package.json since we are currently on node v18.12.1
  2. Updated the styles for the .band class as they weren't showing up with the correct width for me in Firefox or Chrome. Open to suggestions on this one as I'm not sure if it's necessary to keep the code or to have it only apply for screens >= 768px.

@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2023

⚠️ No Changeset found

Latest commit: 766afc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added work in progress POC / Not ready for review doc labels Jan 3, 2023
@github-actions github-actions bot added this to In progress in Workflow Jan 3, 2023
@brianferry brianferry changed the title fix: Updating band styles & node engine in package.json fix: doc band padding & node engine increment in package.json Jan 3, 2023
@github-actions github-actions bot added the AT passed Automated testing has passed label Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit eabd2c6
😎 Deploy Preview https://deploy-preview-2297--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

package.json Outdated Show resolved Hide resolved
Workflow automation moved this from In progress to Ready: code & design review Jan 3, 2023
@bennypowers
Copy link
Member

Padding changes are fine by me. I suggest we not get too caught up here, presumably we'll want to redesign at one point

@bennypowers bennypowers changed the title fix: doc band padding & node engine increment in package.json docs: band padding & node engine increment in package.json Jan 3, 2023
Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com>
@brianferry brianferry marked this pull request as ready for review January 3, 2023 16:41
@brianferry brianferry enabled auto-merge (squash) January 3, 2023 16:41
Workflow automation moved this from Ready: code & design review to Approved Jan 3, 2023
@brianferry brianferry merged commit 0dd5fdd into main Jan 3, 2023
Workflow automation moved this from Approved to Done Jan 3, 2023
@brianferry brianferry deleted the fix/updating-package-json-node-engine-18 branch January 3, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed work in progress POC / Not ready for review
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants