Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update quick start with build step #2307

Merged
merged 2 commits into from Jan 11, 2023
Merged

docs: update quick start with build step #2307

merged 2 commits into from Jan 11, 2023

Conversation

eyevana
Copy link
Contributor

@eyevana eyevana commented Jan 10, 2023

Updated quick start instructions in README

What has changed and why

  • I had to build all the components before running a local dev server in order for the demo site to work properly.

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@eyevana eyevana added ready: code review Ready for code review! priority: low Severity level: 3 labels Jan 10, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

⚠️ No Changeset found

Latest commit: 32cab4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added this to In progress in Workflow Jan 10, 2023
@github-actions github-actions bot added the AT passed Automated testing has passed label Jan 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 8e2660b
😎 Deploy Preview https://deploy-preview-2307--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Workflow automation moved this from In progress to Approved Jan 11, 2023
@bennypowers
Copy link
Member

Thanks @eyevana!

@bennypowers bennypowers enabled auto-merge (rebase) January 11, 2023 08:12
@bennypowers bennypowers merged commit 01a340e into main Jan 11, 2023
15 checks passed
Workflow automation moved this from Approved to Done Jan 11, 2023
@bennypowers bennypowers deleted the eyevana-patch-1 branch January 11, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed priority: low Severity level: 3 ready: code review Ready for code review!
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants