Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jump-links): roving tab-index #2309

Merged
merged 7 commits into from Jan 13, 2023
Merged

fix(jump-links): roving tab-index #2309

merged 7 commits into from Jan 13, 2023

Conversation

nikkimk
Copy link
Collaborator

@nikkimk nikkimk commented Jan 12, 2023

##What I Did

  • Added roving-tabindex-controller.js to pfe-core
  • Used the controller with pfe-jump-links

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2023 •
edited

⚠️ No Changeset found

Latest commit: 63ed2a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nikkimk nikkimk self-assigned this Jan 12, 2023
@github-actions github-actions bot added demo Updating demo pages doc functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools labels Jan 12, 2023
@github-actions github-actions bot added this to In progress in Workflow Jan 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023 •
edited

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit aea52c0
😎 Deploy Preview https://deploy-preview-2309--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jan 12, 2023
@bennypowers bennypowers changed the base branch from main to 2050-11-pfe-jump-links January 13, 2023 04:45
@bennypowers bennypowers changed the title Fix/jump links/a11y fix(jump-links): roving tab-index Jan 13, 2023
@github-actions github-actions bot removed doc tools Development and build tools styles An issue or PR pertaining only to CSS/Sass demo Updating demo pages labels Jan 13, 2023
@bennypowers bennypowers merged commit 957d17b into 2050-11-pfe-jump-links Jan 13, 2023
5 of 7 checks passed
Workflow automation moved this from In progress to Done Jan 13, 2023
@bennypowers bennypowers deleted the fix/jump-links/a11y branch January 13, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennypowers bennypowers Awaiting requested review from bennypowers

Assignees

@nikkimk nikkimk

Labels
AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. tests Related to testing
Projects
Workflow
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikkimk @bennypowers