New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: elements #2316
chore!: elements #2316
Conversation
🦋 Changeset detectedLatest commit: dca949e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting package.json:80:5 Script "build:create" not found in the scripts section of this package.json. "build:create" when I do an install.
|
Thanks, @nikkimk. Until google/wireit#644, all the wireit targets have to be listed in the |
|
@bennypowers - Pushed an update to the branch which should fix the component imports on the demo pages, only thing left on those is that the icons aren't importing (they look like they might need an import map fix or maybe a url fix? The js is there, it just isn't point from |
|
@bennypowers - Icons & Demos look great, core looks good, |
|
Thanks, @brianferry ! |
|
Looking at elements/pfe-s* to /pfe-t* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look and work great, there is a noticeable performance increase in launching the dev server. Nice Work!
|
This will need a squash-and-merge when it's ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of elements looks good.
What I did
A lot, turns out:
Infrastructure
npm start, generally made running repo scripts a smoother experiencePackages
pfe-sassandpfe-stylesDocs
Stuff that works
npm run buildnpm start(here)npm start(in rhds)npm run docsdonpm run docs --watchnpm startdeploy preview