Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: elements #2316

Merged
merged 74 commits into from Jan 26, 2023
Merged

chore!: elements #2316

merged 74 commits into from Jan 26, 2023

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Jan 18, 2023

What I did

A lot, turns out:

Infrastructure

  • removed percy
  • removed last vestiges of sass/scss
  • removed lerna, npm-run-all, added wireit
  • add 11ty and dev server to npm start, generally made running repo scripts a smoother experience
  • upgrade to 11ty 2

Packages

  • combined elements into single package
  • removed pfe-sass and pfe-styles
  • change all element scss to css

Docs

  • update element screenshots
  • add 'landing page' to dev server
  • add tabs to homepage with framework snippets

Stuff that works

  • npm run build
  • npm start (here)
  • npm start (in rhds)
  • npm run docs
  • npm run docs --watch do npm start
  • generator (here)
  • generator (in rhds)

deploy preview

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023

🦋 Changeset detected

Latest commit: dca949e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@patternfly/pfe-core Major
@patternfly/elements Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added work in progress POC / Not ready for review demo Updating demo pages doc functionality Functionality, typically pertaining to the JavaScript. generator Updates relating to the generator styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools labels Jan 18, 2023
@github-actions github-actions bot added this to In progress in Workflow Jan 18, 2023
@github-actions github-actions bot added the AT passed Automated testing has passed label Jan 18, 2023
@nikkimk nikkimk self-requested a review January 18, 2023 18:29
Copy link
Collaborator

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting package.json:80:5 Script "build:create" not found in the scripts section of this package.json. "build:create" when I do an install.

@bennypowers
Copy link
Member Author

Thanks, @nikkimk. Until google/wireit#644, all the wireit targets have to be listed in the scripts blocks, so I fixed that up

@brianferry
Copy link
Collaborator

@bennypowers - Pushed an update to the branch which should fix the component imports on the demo pages, only thing left on those is that the icons aren't importing (they look like they might need an import map fix or maybe a url fix? The js is there, it just isn't point from /icons/fab/angle-right.js -> /components/icon/icons/fab/angle-right.js

@bennypowers
Copy link
Member Author

bennypowers commented Jan 26, 2023

@brianferry PTAL at e9dbac1
https://deploy-preview-2316--patternfly-elements.netlify.app/components/icon/demo/

@brianferry
Copy link
Collaborator

@bennypowers - Icons & Demos look great, core looks good, npm run start and dependencies are all running as expected. Create-element looks good to me too 👍. Docs looks good. Very tiny commit for the demo button styling on the "All Elements" page.

@bennypowers
Copy link
Member Author

Thanks, @brianferry !

@nikkimk
Copy link
Collaborator

nikkimk commented Jan 26, 2023

Looking at elements/pfe-s* to /pfe-t*

Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look and work great, there is a noticeable performance increase in launching the dev server. Nice Work!

@bennypowers
Copy link
Member Author

This will need a squash-and-merge when it's ready

Copy link
Collaborator

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of elements looks good.

@heyMP heyMP merged commit aa2e369 into main Jan 26, 2023
14 checks passed
Workflow automation moved this from Approved to Done Jan 26, 2023
@heyMP heyMP deleted the chore/elements branch January 26, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:1 Aligning components with PatternFly v4 AT passed Automated testing has passed demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. generator Updates relating to the generator styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools work in progress POC / Not ready for review
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants