Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(avatar): typescript build errors #2330

Merged
merged 1 commit into from Feb 1, 2023
Merged

fix(avatar): typescript build errors #2330

merged 1 commit into from Feb 1, 2023

Conversation

zeroedin
Copy link
Collaborator

What I did

  • Fixed pf-avatar typescript build errors. Added more type checking.

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2023

⚠️ No Changeset found

Latest commit: 9df4b19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zeroedin zeroedin self-assigned this Jan 31, 2023
@github-actions github-actions bot added work in progress POC / Not ready for review functionality Functionality, typically pertaining to the JavaScript. tests Related to testing labels Jan 31, 2023
@github-actions github-actions bot added this to In progress in Workflow Jan 31, 2023
@zeroedin zeroedin marked this pull request as ready for review January 31, 2023 22:45
@github-actions
Copy link
Contributor

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit c9ce615
😎 Deploy Preview https://deploy-preview-2330--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jan 31, 2023
Workflow automation moved this from In progress to Approved Feb 1, 2023
@bennypowers bennypowers enabled auto-merge (rebase) February 1, 2023 04:07
@bennypowers bennypowers merged commit 96fc54f into main Feb 1, 2023
22 checks passed
Workflow automation moved this from Approved to Done Feb 1, 2023
@bennypowers bennypowers deleted the fix/avatar/typescript-errors branch February 1, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennypowers bennypowers bennypowers approved these changes

Assignees

@zeroedin zeroedin

Labels
AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. tests Related to testing work in progress POC / Not ready for review
Projects
Workflow
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeroedin @bennypowers