From 85b9c73c1199cc04dccb651d4938326d9f1b5c0c Mon Sep 17 00:00:00 2001 From: "[ Cassondra ]" Date: Fri, 1 Nov 2019 11:47:05 -0400 Subject: [PATCH 1/4] [dev]: Updates to support new compilation approach --- elements/pfelement/package.json | 3 ++- .../src/{pfelement-noscript.css => pfelement--noscript.css} | 0 2 files changed, 2 insertions(+), 1 deletion(-) rename elements/pfelement/src/{pfelement-noscript.css => pfelement--noscript.css} (100%) diff --git a/elements/pfelement/package.json b/elements/pfelement/package.json index 799f4c5bb6..d2ce156d52 100644 --- a/elements/pfelement/package.json +++ b/elements/pfelement/package.json @@ -2,7 +2,8 @@ "name": "@patternfly/pfelement", "pfelement": { "className": "PFElement", - "elementName": "pfelement" + "elementName": "pfelement", + "assets": [ "pfelement.css" ] }, "version": "1.0.0-prerelease.27", "publishConfig": { diff --git a/elements/pfelement/src/pfelement-noscript.css b/elements/pfelement/src/pfelement--noscript.css similarity index 100% rename from elements/pfelement/src/pfelement-noscript.css rename to elements/pfelement/src/pfelement--noscript.css From 20e6c4cf2bc195c22a498e32bd4f84b63ed5f4fa Mon Sep 17 00:00:00 2001 From: "[ Cassondra ]" Date: Fri, 1 Nov 2019 11:53:50 -0400 Subject: [PATCH 2/4] [dev]: Update assets for pfelement --- elements/pfelement/package.json | 5 +- package-lock.json | 81 ++++++++++++++++++++------------- 2 files changed, 54 insertions(+), 32 deletions(-) diff --git a/elements/pfelement/package.json b/elements/pfelement/package.json index d2ce156d52..90247c533b 100644 --- a/elements/pfelement/package.json +++ b/elements/pfelement/package.json @@ -3,7 +3,10 @@ "pfelement": { "className": "PFElement", "elementName": "pfelement", - "assets": [ "pfelement.css" ] + "assets": [ + "pfelement.*css", + "pfelement.*css.map" + ] }, "version": "1.0.0-prerelease.27", "publishConfig": { diff --git a/package-lock.json b/package-lock.json index 7b81bd1f84..5a0e9eb42e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -8967,7 +8967,7 @@ "dependencies": { "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true }, @@ -10069,7 +10069,7 @@ }, "query-string": { "version": "5.1.1", - "resolved": "https://registry.npmjs.org/query-string/-/query-string-5.1.1.tgz", + "resolved": "http://registry.npmjs.org/query-string/-/query-string-5.1.1.tgz", "integrity": "sha512-gjWOsm2SoGlgLEdAGt7a6slVOk9mGiXmPFMqrEhLQ68rhQuBnpfs3+EmlvqKyxnCo9/PPlF+9MtY02S1aFg+Jw==", "dev": true, "requires": { @@ -10529,7 +10529,7 @@ "dependencies": { "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true } @@ -15346,7 +15346,8 @@ "version": "2.1.1", "resolved": false, "integrity": "sha1-w7M6te42DYbg5ijwRorn7yfWVN8=", - "dev": true + "dev": true, + "optional": true }, "aproba": { "version": "1.2.0", @@ -15370,13 +15371,15 @@ "version": "1.0.0", "resolved": false, "integrity": "sha1-ibTRmasr7kneFk6gK4nORi1xt2c=", - "dev": true + "dev": true, + "optional": true }, "brace-expansion": { "version": "1.1.11", "resolved": false, "integrity": "sha512-iCuPHDFgrHX7H2vEI/5xpz07zSHB00TpugqhmYtVmMO6518mCuRMoOYFldEBl0g187ufozdaHgWKcYFb61qGiA==", "dev": true, + "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -15393,19 +15396,22 @@ "version": "1.1.0", "resolved": false, "integrity": "sha1-DQcLTQQ6W+ozovGkDi7bPZpMz3c=", - "dev": true + "dev": true, + "optional": true }, "concat-map": { "version": "0.0.1", "resolved": false, "integrity": "sha1-2Klr13/Wjfd5OnMDajug1UBdR3s=", - "dev": true + "dev": true, + "optional": true }, "console-control-strings": { "version": "1.1.0", "resolved": false, "integrity": "sha1-PXz0Rk22RG6mRL9LOVB/mFEAjo4=", - "dev": true + "dev": true, + "optional": true }, "core-util-is": { "version": "1.0.2", @@ -15536,7 +15542,8 @@ "version": "2.0.3", "resolved": false, "integrity": "sha1-Yzwsg+PaQqUC9SRmAiSA9CCCYd4=", - "dev": true + "dev": true, + "optional": true }, "ini": { "version": "1.3.5", @@ -15550,6 +15557,7 @@ "resolved": false, "integrity": "sha1-754xOG8DGn8NZDr4L95QxFfvAMs=", "dev": true, + "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -15566,6 +15574,7 @@ "resolved": false, "integrity": "sha512-yJHVQEhyqPLUTgt9B83PXu6W3rx4MvvHvSUvToogpwoGDOUQ+yDrR0HRot+yOCdCO7u4hX3pWft6kWBBcqh0UA==", "dev": true, + "optional": true, "requires": { "brace-expansion": "^1.1.7" } @@ -15574,13 +15583,15 @@ "version": "0.0.8", "resolved": false, "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=", - "dev": true + "dev": true, + "optional": true }, "minipass": { "version": "2.3.5", "resolved": false, "integrity": "sha512-Gi1W4k059gyRbyVUZQ4mEqLm0YIUiGYfvxhF6SIlk3ui1WVxMTGfGdQ2SInh3PDrRTVvPKgULkpJtT4RH10+VA==", "dev": true, + "optional": true, "requires": { "safe-buffer": "^5.1.2", "yallist": "^3.0.0" @@ -15601,6 +15612,7 @@ "resolved": false, "integrity": "sha1-MAV0OOrGz3+MR2fzhkjWaX11yQM=", "dev": true, + "optional": true, "requires": { "minimist": "0.0.8" } @@ -15689,7 +15701,8 @@ "version": "1.0.1", "resolved": false, "integrity": "sha1-CXtgK1NCKlIsGvuHkDGDNpQaAR0=", - "dev": true + "dev": true, + "optional": true }, "object-assign": { "version": "4.1.1", @@ -15703,6 +15716,7 @@ "resolved": false, "integrity": "sha1-WDsap3WWHUsROsF9nFC6753Xa9E=", "dev": true, + "optional": true, "requires": { "wrappy": "1" } @@ -15798,7 +15812,8 @@ "version": "5.1.2", "resolved": false, "integrity": "sha512-Gd2UZBJDkXlY7GbJxfsE8/nvKkUEU1G38c1siN6QP6a9PT9MmHB8GnpscSmMJSoF8LOIrt8ud/wPtojys4G6+g==", - "dev": true + "dev": true, + "optional": true }, "safer-buffer": { "version": "2.1.2", @@ -15840,6 +15855,7 @@ "resolved": false, "integrity": "sha1-EYvfW4zcUaKn5w0hHgfisLmxB9M=", "dev": true, + "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0", @@ -15861,6 +15877,7 @@ "resolved": false, "integrity": "sha1-ajhfuIU9lS1f8F0Oiq+UJ43GPc8=", "dev": true, + "optional": true, "requires": { "ansi-regex": "^2.0.0" } @@ -15909,13 +15926,15 @@ "version": "1.0.2", "resolved": false, "integrity": "sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8=", - "dev": true + "dev": true, + "optional": true }, "yallist": { "version": "3.0.3", "resolved": false, "integrity": "sha512-S+Zk8DEWE6oKpV+vI3qWkaK+jSbIK86pCwe2IF/xwIpQ8jEuxpw9NyaGjmp9+BoJv5FV2piqCDcoCtStppiq2A==", - "dev": true + "dev": true, + "optional": true } } }, @@ -16240,7 +16259,7 @@ }, "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true }, @@ -16803,7 +16822,7 @@ }, "got": { "version": "6.7.1", - "resolved": "https://registry.npmjs.org/got/-/got-6.7.1.tgz", + "resolved": "http://registry.npmjs.org/got/-/got-6.7.1.tgz", "integrity": "sha1-JAzQV4WpoY5WHcG0S0HHY+8ejbA=", "dev": true, "requires": { @@ -16928,7 +16947,7 @@ }, "load-json-file": { "version": "1.1.0", - "resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-1.1.0.tgz", + "resolved": "http://registry.npmjs.org/load-json-file/-/load-json-file-1.1.0.tgz", "integrity": "sha1-lWkFcI1YtLq0wiYbBPWfMcmTdMA=", "dev": true, "requires": { @@ -20065,7 +20084,7 @@ }, "json5": { "version": "0.5.1", - "resolved": "https://registry.npmjs.org/json5/-/json5-0.5.1.tgz", + "resolved": "http://registry.npmjs.org/json5/-/json5-0.5.1.tgz", "integrity": "sha1-Hq3nrMASA0rYTiOWdn6tn6VJWCE=", "dev": true }, @@ -20939,7 +20958,7 @@ }, "load-json-file": { "version": "2.0.0", - "resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz", + "resolved": "http://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz", "integrity": "sha1-eUfkIUmvgNaWy/eXvKq8/h/inKg=", "dev": true, "requires": { @@ -21613,7 +21632,7 @@ "dependencies": { "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true } @@ -22471,7 +22490,7 @@ }, "load-json-file": { "version": "1.1.0", - "resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-1.1.0.tgz", + "resolved": "http://registry.npmjs.org/load-json-file/-/load-json-file-1.1.0.tgz", "integrity": "sha1-lWkFcI1YtLq0wiYbBPWfMcmTdMA=", "dev": true, "requires": { @@ -22484,7 +22503,7 @@ }, "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true }, @@ -22683,7 +22702,7 @@ }, "minimist": { "version": "0.0.8", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz", "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=", "dev": true }, @@ -24329,7 +24348,7 @@ }, "onetime": { "version": "1.1.0", - "resolved": "https://registry.npmjs.org/onetime/-/onetime-1.1.0.tgz", + "resolved": "http://registry.npmjs.org/onetime/-/onetime-1.1.0.tgz", "integrity": "sha1-ofeDj4MUxRbwXs78vEzP4EtO14k=", "dev": true }, @@ -24451,7 +24470,7 @@ "dependencies": { "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true } @@ -24470,7 +24489,7 @@ }, "p-cancelable": { "version": "0.4.1", - "resolved": "https://registry.npmjs.org/p-cancelable/-/p-cancelable-0.4.1.tgz", + "resolved": "http://registry.npmjs.org/p-cancelable/-/p-cancelable-0.4.1.tgz", "integrity": "sha512-HNa1A8LvB1kie7cERyy21VNeHb2CWJJYqyyC2o3klWFfMGlFmWv2Z7sFgZH8ZiaYL95ydToKTFVXgMV/Os0bBQ==", "dev": true }, @@ -27171,7 +27190,7 @@ "dependencies": { "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true } @@ -30947,7 +30966,7 @@ }, "strip-ansi": { "version": "3.0.1", - "resolved": "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz", + "resolved": "http://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz", "integrity": "sha1-ajhfuIU9lS1f8F0Oiq+UJ43GPc8=", "dev": true, "requires": { @@ -31714,7 +31733,7 @@ }, "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true }, @@ -31767,7 +31786,7 @@ "dependencies": { "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "dev": true } @@ -35735,7 +35754,7 @@ }, "load-json-file": { "version": "1.1.0", - "resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-1.1.0.tgz", + "resolved": "http://registry.npmjs.org/load-json-file/-/load-json-file-1.1.0.tgz", "integrity": "sha1-lWkFcI1YtLq0wiYbBPWfMcmTdMA=", "dev": true, "requires": { From 6c72df89c46cd537a0723e5bfb8c4a6490ae7583 Mon Sep 17 00:00:00 2001 From: "[ Cassondra ]" Date: Fri, 1 Nov 2019 12:09:31 -0400 Subject: [PATCH 3/4] [dev]: Add changelog --- CHANGELOG-prerelease.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG-prerelease.md b/CHANGELOG-prerelease.md index d3717ed0fb..eb1582e3e7 100644 --- a/CHANGELOG-prerelease.md +++ b/CHANGELOG-prerelease.md @@ -10,7 +10,8 @@ Tag: [v1.0.0-prerelease.28](https://github.com/patternfly/patternfly-elements/re - [5103c95](https://github.com/patternfly/patternfly-elements/commit/5103c950d8d0df1769ffe2291a46f1c867dc0b8a) pfe-navigation style updates - [6ddbcff](https://github.com/patternfly/patternfly-elements/commit/6ddbcffa50bb277a3e48c7b729becd1db646425e) fix: pfe-tabs in IE11 - [782f8e9](https://github.com/patternfly/patternfly-elements/commit/782f8e9ec9cf1e1961acd6bb9bc406d715837706) fix: updating pfe-card story so image overflow works #599 -- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-icon stretch +- [f111593](https://github.com/patternfly/patternfly-elements/commit/f111593805390b1395c284d5905a2e530f829e01) fix: pfe-icon stretch +- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfelement compilation of css assets ## Prerelease 27 ( 2019-10-25 ) From 3857d714b86c90e24ca46e8ab342567285f45b78 Mon Sep 17 00:00:00 2001 From: "[ Cassondra ]" Date: Fri, 1 Nov 2019 12:15:20 -0400 Subject: [PATCH 4/4] [dev]: Rename pfelement--noscript.css throughout the project --- docs/content/develop/step-2b.md | 2 +- elements/pfe-accordion/demo/index.html | 2 +- elements/pfe-autocomplete/demo/index.html | 2 +- elements/pfe-avatar/demo/index.html | 2 +- elements/pfe-band/demo/index.html | 2 +- elements/pfe-card/demo/index.html | 2 +- elements/pfe-collapse/demo/index.html | 2 +- elements/pfe-content-set/demo/index.html | 2 +- elements/pfe-cta/demo/index.html | 2 +- elements/pfe-datetime/demo/index.html | 2 +- elements/pfe-health-index/demo/index.html | 2 +- elements/pfe-icon-panel/demo/index.html | 2 +- elements/pfe-icon/demo/index.html | 2 +- elements/pfe-icon/demo/use-duplicate.html | 2 +- elements/pfe-icon/demo/use-img.html | 2 +- elements/pfe-icon/demo/use-local.html | 2 +- elements/pfe-icon/demo/use-remote.html | 2 +- elements/pfe-markdown/demo/index.html | 2 +- elements/pfe-modal/demo/index.html | 2 +- elements/pfe-navigation/demo/index.html | 4 ++-- elements/pfe-number/demo/index.html | 2 +- elements/pfe-page-status/demo/index.html | 2 +- elements/pfe-progress-indicator/demo/index.html | 2 +- elements/pfe-tabs/demo/index.html | 2 +- elements/pfelement/demo/index.html | 2 +- elements/pfelement/test/fouc-test.html | 2 +- elements/pfelement/test/module-amd-test.html | 2 +- elements/pfelement/test/module-esm-test.html | 2 +- elements/pfelement/test/module-global-test.html | 2 +- 29 files changed, 30 insertions(+), 30 deletions(-) diff --git a/docs/content/develop/step-2b.md b/docs/content/develop/step-2b.md index 855f84c148..74accae945 100644 --- a/docs/content/develop/step-2b.md +++ b/docs/content/develop/step-2b.md @@ -33,7 +33,7 @@ We'll also need to update `/demo/index.html` so that the user's name is passed i PatternFly Element | pfe-cool-element Demo diff --git a/elements/pfe-accordion/demo/index.html b/elements/pfe-accordion/demo/index.html index c46117e2e2..d8d05c9664 100644 --- a/elements/pfe-accordion/demo/index.html +++ b/elements/pfe-accordion/demo/index.html @@ -9,7 +9,7 @@ --> diff --git a/elements/pfe-autocomplete/demo/index.html b/elements/pfe-autocomplete/demo/index.html index 1a04a39e86..79dcd689ae 100644 --- a/elements/pfe-autocomplete/demo/index.html +++ b/elements/pfe-autocomplete/demo/index.html @@ -5,7 +5,7 @@ PFElements: pfe-autocomplete Demo diff --git a/elements/pfe-avatar/demo/index.html b/elements/pfe-avatar/demo/index.html index e90bed433f..f36110fcfa 100644 --- a/elements/pfe-avatar/demo/index.html +++ b/elements/pfe-avatar/demo/index.html @@ -5,7 +5,7 @@ PFElements: pfe-avatar Demo diff --git a/elements/pfe-band/demo/index.html b/elements/pfe-band/demo/index.html index d5229bacf5..09dee917a2 100644 --- a/elements/pfe-band/demo/index.html +++ b/elements/pfe-band/demo/index.html @@ -7,7 +7,7 @@ PatternFly Element: Band Demo diff --git a/elements/pfe-card/demo/index.html b/elements/pfe-card/demo/index.html index aa9b434396..d7fb06ff50 100644 --- a/elements/pfe-card/demo/index.html +++ b/elements/pfe-card/demo/index.html @@ -21,7 +21,7 @@ diff --git a/elements/pfe-collapse/demo/index.html b/elements/pfe-collapse/demo/index.html index 9154c6096a..83ceb63591 100644 --- a/elements/pfe-collapse/demo/index.html +++ b/elements/pfe-collapse/demo/index.html @@ -6,7 +6,7 @@ PatternFly Element | pfe-collapse Demo diff --git a/elements/pfe-content-set/demo/index.html b/elements/pfe-content-set/demo/index.html index ba00058592..e27eb1f85f 100644 --- a/elements/pfe-content-set/demo/index.html +++ b/elements/pfe-content-set/demo/index.html @@ -16,7 +16,7 @@ diff --git a/elements/pfelement/demo/index.html b/elements/pfelement/demo/index.html index f8e538403b..d12881ca59 100644 --- a/elements/pfelement/demo/index.html +++ b/elements/pfelement/demo/index.html @@ -10,7 +10,7 @@ diff --git a/elements/pfelement/test/fouc-test.html b/elements/pfelement/test/fouc-test.html index b5bf0b90ad..55c409aad7 100644 --- a/elements/pfelement/test/fouc-test.html +++ b/elements/pfelement/test/fouc-test.html @@ -9,7 +9,7 @@ diff --git a/elements/pfelement/test/module-amd-test.html b/elements/pfelement/test/module-amd-test.html index 2d4d4e5ef8..a6e48e6a6d 100644 --- a/elements/pfelement/test/module-amd-test.html +++ b/elements/pfelement/test/module-amd-test.html @@ -11,7 +11,7 @@ diff --git a/elements/pfelement/test/module-esm-test.html b/elements/pfelement/test/module-esm-test.html index 73b6f296b2..4fae672219 100644 --- a/elements/pfelement/test/module-esm-test.html +++ b/elements/pfelement/test/module-esm-test.html @@ -9,7 +9,7 @@ diff --git a/elements/pfelement/test/module-global-test.html b/elements/pfelement/test/module-global-test.html index 1e1ca93a72..50b1f47c36 100644 --- a/elements/pfelement/test/module-global-test.html +++ b/elements/pfelement/test/module-global-test.html @@ -11,7 +11,7 @@