Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal-box): added modal description element #2646

Merged
merged 1 commit into from Feb 7, 2020
Merged

feat(modal-box): added modal description element #2646

merged 1 commit into from Feb 7, 2020

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Jan 30, 2020

fixes #2636

@patternfly-build
Copy link

PatternFly-Next preview: https://patternfly-next-pr-2646.surge.sh

mcarrano
mcarrano approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

maryshak1996
maryshak1996 approved these changes Jan 31, 2020
View reviewed changes
Copy link

@maryshak1996 maryshak1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works just like we discussed yesterday, so looks great to me!

mattnolting
mattnolting approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christiemolloy
christiemolloy approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@christiemolloy christiemolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM

@christiemolloy christiemolloy merged commit 5686278 into patternfly:master Feb 7, 2020
@redallen
Copy link
Contributor

redallen commented Feb 7, 2020

🎉 This PR is included in version 2.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Feb 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnolting mattnolting mattnolting approved these changes

@mcarrano mcarrano mcarrano approved these changes

@maryshak1996 maryshak1996 maryshak1996 approved these changes

@christiemolloy christiemolloy christiemolloy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mcoker @patternfly-build @redallen @mattnolting @mcarrano @maryshak1996 @christiemolloy