From cfe146f1ab2ac469d06e038f1c0a4ddfb17ea931 Mon Sep 17 00:00:00 2001 From: Dan Labrecque Date: Sun, 17 Jun 2018 23:25:22 -0400 Subject: [PATCH] fix(tree-list): deprecated for Angular 6 compatibility (#376) Deprecated the tree-list component due to issues with Angular 6 and mobx autorun, introduced by angular-tree-component. Fixes https://github.com/patternfly/patternfly-ng/issues/381 --- .../example/tree-list-example.component.html | 2 +- src/app/list/tree-list/tree-list-config.ts | 5 +++++ src/app/list/tree-list/tree-list.component.ts | 5 +++++ src/app/list/tree-list/tree-list.module.ts | 12 +++++++++++- 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/app/list/tree-list/example/tree-list-example.component.html b/src/app/list/tree-list/example/tree-list-example.component.html index 47b73398a..b728c8c86 100644 --- a/src/app/list/tree-list/example/tree-list-example.component.html +++ b/src/app/list/tree-list/example/tree-list-example.component.html @@ -1,7 +1,7 @@
-

Tree List Component Example

+

Tree List Component Example (deprecated)


diff --git a/src/app/list/tree-list/tree-list-config.ts b/src/app/list/tree-list/tree-list-config.ts index 12a2e803b..14ea33018 100644 --- a/src/app/list/tree-list/tree-list-config.ts +++ b/src/app/list/tree-list/tree-list-config.ts @@ -2,6 +2,11 @@ import { ListConfigBase } from '../list-config-base'; /** * A config containing properties for tree list + * + * @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun, + * introduced by angular-tree-component. + * + * See: https://github.com/patternfly/patternfly-ng/issues/381 */ export class TreeListConfig extends ListConfigBase { /** diff --git a/src/app/list/tree-list/tree-list.component.ts b/src/app/list/tree-list/tree-list.component.ts index b66c897ef..43180b183 100644 --- a/src/app/list/tree-list/tree-list.component.ts +++ b/src/app/list/tree-list/tree-list.component.ts @@ -34,6 +34,11 @@ import { TreeListConfig } from './tree-list-config'; * * Or: *
import { TreeListModule } from 'patternfly-ng'; + * + * @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun, + * introduced by angular-tree-component. + * + * See: https://github.com/patternfly/patternfly-ng/issues/381 */ @Component({ encapsulation: ViewEncapsulation.None, diff --git a/src/app/list/tree-list/tree-list.module.ts b/src/app/list/tree-list/tree-list.module.ts index 6b5096a25..302627e1a 100644 --- a/src/app/list/tree-list/tree-list.module.ts +++ b/src/app/list/tree-list/tree-list.module.ts @@ -9,6 +9,11 @@ import { TreeListComponent } from './tree-list.component'; /** * A module containing objects associated with tree list components + * + * @deprecated The tree-list component is deprecated due to issues with Angular 6 and mobx autorun, + * introduced by angular-tree-component. + * + * See: https://github.com/patternfly/patternfly-ng/issues/381 */ @NgModule({ imports: [ @@ -20,4 +25,9 @@ import { TreeListComponent } from './tree-list.component'; declarations: [TreeListComponent], exports: [TreeListComponent] }) -export class TreeListModule {} +export class TreeListModule { + constructor() { + console.log('patternfly-ng: The tree-list component is deprecated due to issues with Angular 6 and ' + + 'mobx autorun, introduced by angular-tree-component.'); + } +}