From ea4eca2c1bf83880b2211baeb79f0762c7eac135 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Fri, 15 May 2026 09:46:23 -0400 Subject: [PATCH 1/3] fix(Cookies/GDPR): moved location in DOM for keyboard a11y --- .../layouts/sideNavLayout/sideNavLayout.css | 4 ++++ .../layouts/sideNavLayout/sideNavLayout.js | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css b/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css index 8b13e97c95..e69878c00b 100644 --- a/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css +++ b/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css @@ -8,6 +8,10 @@ flex: 1; } +#ws-page-banners { + z-index: 9999; +} + /* Search */ #algolia-autocomplete-listbox-0 { /* Fix search results overflowing page */ diff --git a/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js b/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js index 38b76252ef..178538a8ad 100644 --- a/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js +++ b/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js @@ -350,6 +350,10 @@ export const SideNavLayout = ({ children, groupedRoutes, navOpen: navOpenProp }) return ( +
+ + {hasGdprBanner && } +
} -
- - {hasGdprBanner && } -
); From 6c2beaef00726f8b341c3b4c289389ee3912e7b6 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Fri, 15 May 2026 09:47:39 -0400 Subject: [PATCH 2/3] Add comment --- .../layouts/sideNavLayout/sideNavLayout.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js b/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js index 178538a8ad..e88574f901 100644 --- a/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js +++ b/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.js @@ -350,6 +350,8 @@ export const SideNavLayout = ({ children, groupedRoutes, navOpen: navOpenProp }) return ( + {/* These alert banners need to be one of the first focusable items so users navigating via + keybaord can dismiss them early in their navigation. */}
{hasGdprBanner && } From 20f3cfd394f2bd8b2cbebbc189950b964d699376 Mon Sep 17 00:00:00 2001 From: Eric Olkowski Date: Fri, 15 May 2026 11:19:02 -0400 Subject: [PATCH 3/3] Used zindex token --- .../layouts/sideNavLayout/sideNavLayout.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css b/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css index e69878c00b..42b1030149 100644 --- a/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css +++ b/packages/documentation-framework/layouts/sideNavLayout/sideNavLayout.css @@ -9,7 +9,7 @@ } #ws-page-banners { - z-index: 9999; + z-index: var(--pf-t--global--z-index--2xl); } /* Search */