Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): add eslint in addition to tslint #75

Merged
merged 2 commits into from Nov 13, 2019

Conversation

@seanforyou23
Copy link
Member

seanforyou23 commented Nov 1, 2019

This PR adds eslint and implements the new dark theme for sidenav.

Closes #74

integrate eslint with pf recommended rules
update deps
adjust test to be more useful
dark theme for sidenav

integrate eslint with pf recommended rules
update deps
adjust test to be more useful
dark theme for sidenav
Copy link

mturley left a comment

This is looking good! I have a few very minor thoughts, you can take them or leave them.

Also as discussed, I think it would be useful to add something to the README explaining why we have both TSLint and ESLint in here, mentioning that TSLint is being deprecated and we're transitioning to ESLint, and that you don't really need both in a project.

.eslintrc Show resolved Hide resolved
.eslintrc Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/app/Dashboard/Dashboard.tsx Show resolved Hide resolved
src/app/DynamicImport.tsx Outdated Show resolved Hide resolved
be more specific about which rules are disabled
update readme
@seanforyou23 seanforyou23 requested a review from mturley Nov 12, 2019
Copy link

mturley left a comment

LGTM!

@seanforyou23 seanforyou23 merged commit b245fa4 into patternfly:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.