Update tippy.js dependency

patternfly · Dec 3, 2019 · 7317963 · 7317963
1 parent 78bd323
commit 7317963
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 51 deletions.
diff --git a/...catalog-view-extension/src/components/CatalogTile/__snapshots__/CatalogTile.test.tsx.snap b/...catalog-view-extension/src/components/CatalogTile/__snapshots__/CatalogTile.test.tsx.snap
@@ -201,7 +201,6 @@ exports[`CatalogTile renders properly 1`] = `
                         zIndex={9999}
                       >
                         <PopoverBase
-                          animateFill={false}
                           appendTo={[Function]}
                           aria="describedby"
                           arrow={true}
@@ -242,7 +241,6 @@ exports[`CatalogTile renders properly 1`] = `
                           lazy={true}
                           maxWidth="18.75rem"
                           onCreate={[Function]}
-                          performance={true}
                           placement="top"
                           popperOptions={
                             Object {
@@ -527,7 +525,6 @@ exports[`CatalogTile renders properly 1`] = `
                         zIndex={9999}
                       >
                         <PopoverBase
-                          animateFill={false}
                           appendTo={[Function]}
                           aria="describedby"
                           arrow={true}
@@ -568,7 +565,6 @@ exports[`CatalogTile renders properly 1`] = `
                           lazy={true}
                           maxWidth="18.75rem"
                           onCreate={[Function]}
-                          performance={true}
                           placement="top"
                           popperOptions={
                             Object {
@@ -697,7 +693,6 @@ exports[`CatalogTile renders properly 1`] = `
                         zIndex={9999}
                       >
                         <PopoverBase
-                          animateFill={false}
                           appendTo={[Function]}
                           aria="describedby"
                           arrow={true}
@@ -738,7 +733,6 @@ exports[`CatalogTile renders properly 1`] = `
                           lazy={true}
                           maxWidth="18.75rem"
                           onCreate={[Function]}
-                          performance={true}
                           placement="top"
                           popperOptions={
                             Object {
@@ -976,7 +970,6 @@ exports[`CatalogTile renders properly 1`] = `
                         zIndex={9999}
                       >
                         <PopoverBase
-                          animateFill={false}
                           appendTo={[Function]}
                           aria="describedby"
                           arrow={true}
@@ -1017,7 +1010,6 @@ exports[`CatalogTile renders properly 1`] = `
                           lazy={true}
                           maxWidth="18.75rem"
                           onCreate={[Function]}
-                          performance={true}
                           placement="top"
                           popperOptions={
                             Object {
@@ -1257,7 +1249,6 @@ exports[`CatalogTile renders properly 1`] = `
                         zIndex={9999}
                       >
                         <PopoverBase
-                          animateFill={false}
                           appendTo={[Function]}
                           aria="describedby"
                           arrow={true}
@@ -1298,7 +1289,6 @@ exports[`CatalogTile renders properly 1`] = `
                           lazy={true}
                           maxWidth="18.75rem"
                           onCreate={[Function]}
-                          performance={true}
                           placement="top"
                           popperOptions={
                             Object {
@@ -1634,7 +1624,6 @@ exports[`CatalogTile renders properly 1`] = `
                         zIndex={9999}
                       >
                         <PopoverBase
-                          animateFill={false}
                           appendTo={[Function]}
                           aria="describedby"
                           arrow={true}
@@ -1675,7 +1664,6 @@ exports[`CatalogTile renders properly 1`] = `
                           lazy={true}
                           maxWidth="18.75rem"
                           onCreate={[Function]}
-                          performance={true}
                           placement="top"
                           popperOptions={
                             Object {

diff --git a/packages/patternfly-4/react-core/package.json b/packages/patternfly-4/react-core/package.json
@@ -45,7 +45,7 @@
     "emotion": "^9.2.9",
     "exenv": "^1.2.2",
     "focus-trap-react": "^4.0.1",
-    "tippy.js": "3.4.1"
+    "tippy.js": "5.1.2"
   },
   "devDependencies": {
     "@babel/cli": "^7.0.0",

diff --git a/packages/patternfly-4/react-core/src/components/Popover/Popover.tsx b/packages/patternfly-4/react-core/src/components/Popover/Popover.tsx
@@ -95,7 +95,7 @@ export interface PopoverProps {
   /** z-index of the popover */
   zIndex?: number;
   /** additional Props to pass through to tippy.js */
-  tippyProps?: TippyProps;
+  tippyProps?: object;
 }
 
 export interface PopoverState {
@@ -283,9 +283,7 @@ export class Popover extends React.Component<PopoverProps, PopoverState> {
         trigger={handleEvents ? 'click' : 'manual'}
         isVisible={isVisible}
         hideOnClick={shouldHideOnClick()}
-        animateFill={false}
         theme="pf-popover"
-        performance
         interactive
         interactiveBorder={0}
         placement={position}

diff --git a/packages/patternfly-4/react-core/src/components/Popover/__snapshots__/Popover.test.tsx.snap b/packages/patternfly-4/react-core/src/components/Popover/__snapshots__/Popover.test.tsx.snap
@@ -2,7 +2,6 @@
 
 exports[`popover can specify position as object value 1`] = `
 <PopoverBase
-  animateFill={false}
   appendTo={[Function]}
   arrow={true}
   boundary="window"
@@ -38,7 +37,6 @@ exports[`popover can specify position as object value 1`] = `
   onMount={[Function]}
   onShow={[Function]}
   onShown={[Function]}
-  performance={true}
   placement="right"
   popperOptions={
     Object {
@@ -64,7 +62,6 @@ exports[`popover can specify position as object value 1`] = `
 
 exports[`popover passes along values to tippy.js 1`] = `
 <PopoverBase
-  animateFill={false}
   appendTo={[Function]}
   arrow={true}
   boundary="window"
@@ -107,7 +104,6 @@ exports[`popover passes along values to tippy.js 1`] = `
   onMount={[Function]}
   onShow={[Function]}
   onShown={[Function]}
-  performance={true}
   placement="right"
   popperOptions={
     Object {
@@ -133,7 +129,6 @@ exports[`popover passes along values to tippy.js 1`] = `
 
 exports[`popover renders close-button, header and body 1`] = `
 <PopoverBase
-  animateFill={false}
   appendTo={[Function]}
   arrow={true}
   boundary="window"
@@ -169,7 +164,6 @@ exports[`popover renders close-button, header and body 1`] = `
   onMount={[Function]}
   onShow={[Function]}
   onShown={[Function]}
-  performance={true}
   placement="top"
   popperOptions={
     Object {

diff --git a/packages/patternfly-4/react-core/src/components/Tooltip/Tooltip.tsx b/packages/patternfly-4/react-core/src/components/Tooltip/Tooltip.tsx
@@ -68,7 +68,7 @@ export interface TooltipProps {
   /** z-index of the tooltip */
   zIndex?: number;
   /** additional Props to pass through to tippy.js */
-  tippyProps?: TippyProps;
+  tippyProps?: object;
   /** ID */
   id?: string;
 }
@@ -167,9 +167,7 @@ export class Tooltip extends React.Component<TooltipProps> {
         appendTo={appendTo}
         content={content}
         lazy
-        animateFill={false}
         theme="pf-tooltip"
-        performance
         placement={position}
         trigger={trigger}
         delay={[entryDelay, exitDelay]}

diff --git a/packages/patternfly-4/react-core/src/components/Tooltip/__snapshots__/Tooltip.test.tsx.snap b/packages/patternfly-4/react-core/src/components/Tooltip/__snapshots__/Tooltip.test.tsx.snap
@@ -2,7 +2,6 @@
 
 exports[`tooltip passes along values to tippy.js 1`] = `
 <PopoverBase
-  animateFill={false}
   appendTo={[Function]}
   aria="describedby"
   arrow={true}
@@ -52,7 +51,6 @@ exports[`tooltip passes along values to tippy.js 1`] = `
   maxWidth="18.75rem"
   offset={20}
   onCreate={[Function]}
-  performance={true}
   placement="top"
   popperOptions={
     Object {
@@ -78,7 +76,6 @@ exports[`tooltip passes along values to tippy.js 1`] = `
 
 exports[`tooltip renders 1`] = `
 <PopoverBase
-  animateFill={false}
   appendTo={[Function]}
   aria="describedby"
   arrow={true}
@@ -121,7 +118,6 @@ exports[`tooltip renders 1`] = `
   lazy={true}
   maxWidth="18.75rem"
   onCreate={[Function]}
-  performance={true}
   placement="top"
   popperOptions={
     Object {

diff --git a/packages/patternfly-4/react-core/src/helpers/PopoverBase/PopoverBase.js b/packages/patternfly-4/react-core/src/helpers/PopoverBase/PopoverBase.js
@@ -28,7 +28,8 @@ class PopoverBase extends React.Component {
     isEnabled: PropTypes.bool,
     isVisible: PropTypes.bool,
     onCreate: PropTypes.func,
-    trigger: PropTypes.string
+    trigger: PropTypes.string,
+    hideOnClick: PropTypes.bool,
   };
 
   static defaultProps = {
@@ -58,7 +59,7 @@ class PopoverBase extends React.Component {
     this.setState({ isMounted: true });
 
     /* eslint-disable-next-line */
-    this.tip = tippy.one(ReactDOM.findDOMNode(this), this.options);
+    this.tip = tippy(ReactDOM.findDOMNode(this), this.options);
 
     const { onCreate, isEnabled, isVisible } = this.props;
 
@@ -76,7 +77,7 @@ class PopoverBase extends React.Component {
   }
 
   componentDidUpdate() {
-    this.tip.set(this.options);
+    this.tip.setProps(this.options);
 
     const { isEnabled, isVisible } = this.props;
 

diff --git a/...topology/src/components/TopologyControlBar/__snapshots__/TopologyControlBar.test.tsx.snap b/...topology/src/components/TopologyControlBar/__snapshots__/TopologyControlBar.test.tsx.snap
@@ -112,7 +112,6 @@ exports[`TopologyControlBar should accept button options correctly 1`] = `
                 zIndex={9999}
               >
                 <PopoverBase
-                  animateFill={false}
                   appendTo={[Function]}
                   aria="describedby"
                   arrow={true}
@@ -153,7 +152,6 @@ exports[`TopologyControlBar should accept button options correctly 1`] = `
                   lazy={true}
                   maxWidth="18.75rem"
                   onCreate={[Function]}
-                  performance={true}
                   placement="top"
                   popperOptions={
                     Object {
@@ -314,7 +312,6 @@ exports[`TopologyControlBar should accept button options correctly 1`] = `
                 zIndex={9999}
               >
                 <PopoverBase
-                  animateFill={false}
                   appendTo={[Function]}
                   aria="describedby"
                   arrow={true}
@@ -355,7 +352,6 @@ exports[`TopologyControlBar should accept button options correctly 1`] = `
                   lazy={true}
                   maxWidth="18.75rem"
                   onCreate={[Function]}
-                  performance={true}
                   placement="top"
                   popperOptions={
                     Object {
@@ -542,7 +538,6 @@ exports[`TopologyControlBar should accept button options correctly 1`] = `
                 zIndex={9999}
               >
                 <PopoverBase
-                  animateFill={false}
                   appendTo={[Function]}
                   aria="describedby"
                   arrow={true}
@@ -583,7 +578,6 @@ exports[`TopologyControlBar should accept button options correctly 1`] = `
                   lazy={true}
                   maxWidth="18.75rem"
                   onCreate={[Function]}
-                  performance={true}
                   placement="top"
                   popperOptions={
                     Object {
@@ -864,7 +858,6 @@ exports[`TopologyControlBar should display the default controls correctly 1`] =
                 zIndex={9999}
               >
                 <PopoverBase
-                  animateFill={false}
                   appendTo={[Function]}
                   aria="describedby"
                   arrow={true}
@@ -905,7 +898,6 @@ exports[`TopologyControlBar should display the default controls correctly 1`] =
                   lazy={true}
                   maxWidth="18.75rem"
                   onCreate={[Function]}
-                  performance={true}
                   placement="top"
                   popperOptions={
                     Object {
@@ -1092,7 +1084,6 @@ exports[`TopologyControlBar should display the default controls correctly 1`] =
                 zIndex={9999}
               >
                 <PopoverBase
-                  animateFill={false}
                   appendTo={[Function]}
                   aria="describedby"
                   arrow={true}
@@ -1133,7 +1124,6 @@ exports[`TopologyControlBar should display the default controls correctly 1`] =
                   lazy={true}
                   maxWidth="18.75rem"
                   onCreate={[Function]}
-                  performance={true}
                   placement="top"
                   popperOptions={
                     Object {
@@ -1320,7 +1310,6 @@ exports[`TopologyControlBar should display the default controls correctly 1`] =
                 zIndex={9999}
               >
                 <PopoverBase
-                  animateFill={false}
                   appendTo={[Function]}
                   aria="describedby"
                   arrow={true}
@@ -1361,7 +1350,6 @@ exports[`TopologyControlBar should display the default controls correctly 1`] =
                   lazy={true}
                   maxWidth="18.75rem"
                   onCreate={[Function]}
-                  performance={true}
                   placement="top"
                   popperOptions={
                     Object {
@@ -1548,7 +1536,6 @@ exports[`TopologyControlBar should display the default controls correctly 1`] =
                 zIndex={9999}
               >
                 <PopoverBase
-                  animateFill={false}
                   appendTo={[Function]}
                   aria="describedby"
                   arrow={true}
@@ -1589,7 +1576,6 @@ exports[`TopologyControlBar should display the default controls correctly 1`] =
                   lazy={true}
                   maxWidth="18.75rem"
                   onCreate={[Function]}
-                  performance={true}
                   placement="top"
                   popperOptions={
                     Object {

diff --git a/yarn.lock b/yarn.lock
@@ -18291,7 +18291,7 @@ polished@^3.3.1:
   dependencies:
     "@babel/runtime" "^7.4.5"
 
-popper.js@^1.14.4, popper.js@^1.14.6, popper.js@^1.14.7:
+popper.js@^1.14.4, popper.js@^1.14.7, popper.js@^1.16.0:
   version "1.16.0"
   resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.16.0.tgz#2e1816bcbbaa518ea6c2e15a466f4cb9c6e2fbb3"
 
@@ -22904,11 +22904,12 @@ tinycolor2@^1.4.1:
   version "1.4.1"
   resolved "https://registry.yarnpkg.com/tinycolor2/-/tinycolor2-1.4.1.tgz#f4fad333447bc0b07d4dc8e9209d8f39a8ac77e8"
 
-tippy.js@3.4.1:
-  version "3.4.1"
-  resolved "https://registry.yarnpkg.com/tippy.js/-/tippy.js-3.4.1.tgz#f0eb3081824ad6c5d364336451ad77ae2f543da8"
+tippy.js@5.1.2:
+  version "5.1.2"
+  resolved "https://registry.yarnpkg.com/tippy.js/-/tippy.js-5.1.2.tgz#5ac91233c59ab482ef5988cffe6e08bd26528e66"
+  integrity sha512-Qtrv2wqbRbaKMUb6bWWBQWPayvcDKNrGlvihxtsyowhT7RLGEh1STWuy6EMXC6QLkfKPB2MLnf8W2mzql9VDAw==
   dependencies:
-    popper.js "^1.14.6"
+    popper.js "^1.16.0"
 
 title-case@^2.1.0:
   version "2.1.1"