Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

donut-utilization-chart: apply defaults to legendComponent #2194

Closed
dlabrecq opened this issue Jun 9, 2019 · 0 comments · Fixed by #2193
Closed

donut-utilization-chart: apply defaults to legendComponent #2194

dlabrecq opened this issue Jun 9, 2019 · 0 comments · Fixed by #2193
Assignees
Milestone

Comments

@dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented Jun 9, 2019

As a user, I want to provide a custom legend in order to override default colors. (For example, we show a grey, dotted symbol for our previous month's data.) However, I still want the chart component to position my legend left/right of the chart.

It would be ideal if the chart would apply default properties to the custom legend, so I don't need to perform complicated positioning calculations.

@dlabrecq dlabrecq self-assigned this Jun 9, 2019
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jun 9, 2019
@dlabrecq dlabrecq changed the title react-charts: apply defaults to legendComponent donut-utilization-chart: apply defaults to legendComponent Jun 10, 2019
@dlabaj dlabaj closed this in #2193 Jun 10, 2019
dlabaj added a commit that referenced this issue Jun 10, 2019
#2193)

* fix(charts): align label vertically and add defaults for donutHeight donutWidth

Fixes #2191
Fixes #2192

* fix(charts): apply defaults to custom legend

#2194
@rachael-phillips rachael-phillips added this to the Albatross milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.