Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow component #2819

Closed
rachael-phillips opened this issue Sep 3, 2019 · 0 comments · Fixed by #2948
Closed

Overflow component #2819

rachael-phillips opened this issue Sep 3, 2019 · 0 comments · Fixed by #2948
Assignees
Labels
Milestone

Comments

@rachael-phillips
Copy link
Contributor

@rachael-phillips rachael-phillips commented Sep 3, 2019

Related issue: patternfly/patternfly-next#2215

This issue should not be started until Core issue is complete

@evwilkin evwilkin self-assigned this Sep 5, 2019
@LHinson LHinson added this to the Prioritized Backlog milestone Sep 6, 2019
@tlabaj tlabaj removed the p1 label Sep 9, 2019
@LHinson LHinson modified the milestones: Prioritized Backlog, 2019.08 Sep 11, 2019
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 17, 2019
@evwilkin evwilkin mentioned this issue Sep 17, 2019
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 24, 2019
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 25, 2019
Made isPersistent and hasAdditionalItems props necessary one level higher on
OverflowMenuContent/OverflowMenuControl as these elements no longer render at all rather than being
hidden, updated tests to reflect changes

re patternfly#2819
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 26, 2019
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 26, 2019
Made isPersistent and hasAdditionalItems props necessary one level higher on
OverflowMenuContent/OverflowMenuControl as these elements no longer render at all rather than being
hidden, updated tests to reflect changes

re patternfly#2819
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 26, 2019
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 26, 2019
Made isPersistent and hasAdditionalItems props necessary one level higher on
OverflowMenuContent/OverflowMenuControl as these elements no longer render at all rather than being
hidden, updated tests to reflect changes

re patternfly#2819
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 26, 2019
evwilkin added a commit to evwilkin/patternfly-react that referenced this issue Sep 26, 2019
Made isPersistent and hasAdditionalItems props necessary one level higher on
OverflowMenuContent/OverflowMenuControl as these elements no longer render at all rather than being
hidden, updated tests to reflect changes

re patternfly#2819
jschuler added a commit that referenced this issue Sep 26, 2019
* feat(overflow-menu): pull in styling

* feat(OverflowMenu): built out .md doc examples

re #2819

* feat(OverflowMenu): resolved DropdownItem import issue and CSS import order issue

* feat(OverflowMenu): renamed OverflowMenuGroup to OverflowMenuContentGroup and OverflowMenuItem to OverflowMenuContentItem to indicate heirarchy

* feat(overflowmenu): added global variables and debouncing for resize

* feat(overflowmenu): implemented Context in place of cloning children

* feat(overflowmenu): improved naming conventions, removed unnecessary vars from state, and updated remove resize listener

* feat(overflowmenu): added unit tests

* feat(overflowmenu): building out integration tests

* feat(overflowmenu): added cypress integration tests

* feat(overflowmenu): PR feedback fixes

changed Button variants from link to plain and used variables for all variants, replaced fa icons
with react icons, renamed OverflowMenuContentItem and OverflowMenuContentGroup to OverflowMenuItem
and OverflowMenuGroup, removed the unneeded "Action" OverflowMenuDropdownItem.

re #2948

* feat(overflowmenu): Lifted state to OverflowMenu

Made isPersistent and hasAdditionalItems props necessary one level higher on
OverflowMenuContent/OverflowMenuControl as these elements no longer render at all rather than being
hidden, updated tests to reflect changes

re #2819

* feat(overflowmenu): renamed wrapperClass on DropdownItem to listItemClassName

* feat(overflowmenu): fixed merge conflicts

* feat(overflowmenu): updated DropdownItem props

* feat(overflowmenu): updated snapshots

* feat(overflowmenu): updated Button snapshot

* feat(overflowmenu): removed default prop value of listItemClassName in DropdownItem, set it to null rather than false in OverflowMenuDropdownItem

* feat(overflowmenu): InternalDropdownItem className defaults to null if false

* feat(overflowmenu): updated snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.