Skip to content

/patternfly-react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifying expandable cellFormatter breaks columns type for table #3148

Closed
seanforyou23 opened this issue Oct 15, 2019 · 0 comments
Closed

Specifying expandable cellFormatter breaks columns type for table #3148

seanforyou23 opened this issue Oct 15, 2019 · 0 comments
Assignees
@seanforyou23
Labels
PF4
Milestone
2019.10

Comments

@seanforyou23
Copy link
Member

@seanforyou23 seanforyou23 commented Oct 15, 2019 •
edited

When I specify cellFormatters: [expandable] as part of a column definition that's typed (ICell | string)[] (as directed in the docs) I get type errors.

I created a branch using pf-seed where you can easily see the problem. The implementation seems to be fine (live demo of the working branch here) but the types complain so I'm forced to supply a type of any[] in the mean time.

Am I just doing it wrong or is it a regression?

Screen Shot 2019-10-16 at 4 32 13 PM
@seanforyou23 seanforyou23 added the PF4 label Oct 15, 2019
@seanforyou23 seanforyou23 mentioned this issue Oct 24, 2019
Merged
@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2019.10 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanforyou23 seanforyou23

Labels
PF4
Projects
None yet
Milestone
  2019.10
2 participants
@seanforyou23 @tlabaj
You can’t perform that action at this time.