Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF4: Add File Upload Component #3735

Closed
tlabaj opened this issue Feb 12, 2020 · 6 comments
Closed

PF4: Add File Upload Component #3735

tlabaj opened this issue Feb 12, 2020 · 6 comments
Assignees
Milestone

Comments

@tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Feb 12, 2020

Describe the issue. What is the expected and unexpected behavior?
Introduce File Upload component according to the UI design here: https://marvelapp.com/de0ggah

This component will be introduced for uploading text files only. The user can upload a file by browsing to it, pasting its contents, or dragging and dropping it.

This is related to core issue patternfly/patternfly#2624

@mturley

This comment has been minimized.

Copy link
Collaborator

@mturley mturley commented Feb 14, 2020

Do we have a timeline for this? I would love to do this, depending on when I can free up some time.

@mturley

This comment has been minimized.

Copy link
Collaborator

@mturley mturley commented Feb 14, 2020

@tlabaj

This comment has been minimized.

Copy link
Contributor Author

@tlabaj tlabaj commented Feb 17, 2020

@mturley We are hoping to get this in for Milestone 2020.03. Code freeze is March 6th. Do you think you can pick it up?

@mturley

This comment has been minimized.

Copy link
Collaborator

@mturley mturley commented Feb 17, 2020

Yes, I think I can start it later this week. It shouldn't take too long, judging by my PF3 implementation.

@mturley mturley self-assigned this Feb 17, 2020
@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2020.03 Feb 18, 2020
@mturley

This comment has been minimized.

Copy link
Collaborator

@mturley mturley commented Feb 21, 2020

I expect to start on this on Monday.

@mturley

This comment has been minimized.

Copy link
Collaborator

@mturley mturley commented Feb 26, 2020

I have an open question about the invalid state, which I detailed in the core PR here (patternfly/patternfly#2681 (comment)) for visibility from folks who were involved in that implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.