Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icons): Add font awesome brands icons #1669

Merged
merged 1 commit into from May 6, 2019

Conversation

@karelhala
Copy link
Contributor

karelhala commented Apr 1, 2019

What:
This PR adds all font awesome brands icons, icon count increased by 426.

Additional issues:
Resolves #1666

@karelhala karelhala requested review from jschuler, dlabaj and redallen Apr 1, 2019
@karelhala karelhala force-pushed the karelhala:brand-icons branch from 89e5ca0 to 115b9f9 Apr 15, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #1669 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1669   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files         601      601           
  Lines        6642     6642           
  Branches       72       72           
=======================================
  Hits         5498     5498           
  Misses       1117     1117           
  Partials       27       27
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.47% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30204e4...115b9f9. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 15, 2019

@tlabaj
tlabaj approved these changes May 6, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes May 6, 2019
@dlabaj dlabaj merged commit 1c58036 into patternfly:master May 6, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.