Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Breadcrumb): Convert Breadcrumb jsx file to tsx #1723

Merged
merged 14 commits into from May 20, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Apr 8, 2019

Fixes issue #1717 by updating breadcrumb to typescript.

@dlabaj dlabaj requested review from dlabaj, tlabaj and redallen Apr 8, 2019
Copy link
Contributor

dlabaj left a comment

A few comments. Also once this gets working I would added these components to our typescript app under react-integration/demo-app-ts

@dlabaj dlabaj self-assigned this Apr 8, 2019
@dlabaj dlabaj added the PF4 label Apr 8, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 8, 2019

Codecov Report

Merging #1723 into master will increase coverage by 0.01%.
The diff coverage is 91.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1723      +/-   ##
==========================================
+ Coverage   81.86%   81.88%   +0.01%     
==========================================
  Files         630      631       +1     
  Lines        7214     7241      +27     
  Branches      291      312      +21     
==========================================
+ Hits         5906     5929      +23     
  Misses       1164     1164              
- Partials      144      148       +4
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 78.03% <91.11%> (+0.05%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...eact-core/src/components/Breadcrumb/Breadcrumb.tsx 100% <100%> (ø)
...ly-4/react-core/src/components/Breadcrumb/index.ts 100% <100%> (ø)
...re/src/components/Breadcrumb/BreadcrumbHeading.tsx 85.71% <85.71%> (ø)
...-core/src/components/Breadcrumb/BreadcrumbItem.tsx 89.47% <89.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9d252...84e0227. Read the comment docs.

@jessiehuff jessiehuff force-pushed the jessiehuff:feat/breadcrumbTS branch from 6bfa8e4 to 507028f Apr 9, 2019
@tlabaj tlabaj added the chore 🏠 label Apr 9, 2019
@jessiehuff jessiehuff force-pushed the jessiehuff:feat/breadcrumbTS branch from 8c5dc1e to 43e1798 Apr 9, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 9, 2019

Copy link
Contributor

redallen left a comment

Good start.

Copy link
Contributor

tlabaj left a comment

A few questions and updates.

@jessiehuff jessiehuff dismissed stale reviews from kmcfaul, dlabaj, and redallen via a0a49b3 May 6, 2019
@jessiehuff jessiehuff force-pushed the jessiehuff:feat/breadcrumbTS branch from a2aa6e3 to 788ed89 May 6, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented May 6, 2019

@jessiehuff jessiehuff force-pushed the jessiehuff:feat/breadcrumbTS branch 2 times, most recently from a2aa6e3 to 473ed94 May 6, 2019
@nicolethoen

This comment has been minimized.

Copy link
Contributor

nicolethoen commented May 8, 2019

@jessiehuff can you also add integration tests for this component as outlined on this README?

@redallen redallen added the TypeScript label May 9, 2019
Copy link
Contributor

tlabaj left a comment

We need to figure out why the test case is rendering the as any rather than 'a'

Jessie
@jessiehuff jessiehuff force-pushed the jessiehuff:feat/breadcrumbTS branch from 7ca295a to 76ac93e May 15, 2019
Copy link
Contributor

tlabaj left a comment

A few more comments.

Copy link
Contributor

tlabaj left a comment

A few more comments.

Jessie added 5 commits May 16, 2019
Jessie
Jessie
Jessie
Jessie
Copy link
Contributor

tlabaj left a comment

Looks like this was updated. I still see some things that are not quite right.

Jessie added 2 commits May 17, 2019
Jessie
Jessie
Copy link
Contributor

tlabaj left a comment

The component?: React.ReactType; Still is not right.

Jessie
Copy link
Contributor

redallen left a comment

Thanks for this!

Copy link
Contributor

dlabaj left a comment

One update to integration test other then that looks good.

Jessie
Jessie added 2 commits May 20, 2019
Jessie
Jessie
@dlabaj
dlabaj approved these changes May 20, 2019
@tlabaj
tlabaj approved these changes May 20, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 9151262 into patternfly:master May 20, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.