Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): add missing props in d.ts #1749

Merged
merged 1 commit into from Apr 23, 2019
Merged

fix(grid): add missing props in d.ts #1749

merged 1 commit into from Apr 23, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Apr 11, 2019

What:

fixes #1718

Added the span, sm, md, lg and xl props in the d.ts file

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 11, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #1749 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1749   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         598      598           
  Lines        6629     6629           
  Branches       72       72           
=======================================
  Hits         5484     5484           
  Misses       1118     1118           
  Partials       27       27
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.34% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b3b70...7e115d3. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #1749 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1749   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         598      598           
  Lines        6629     6629           
  Branches       72       72           
=======================================
  Hits         5484     5484           
  Misses       1118     1118           
  Partials       27       27
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.34% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b3b70...6764a37. Read the comment docs.

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@boaz0 boaz0 force-pushed the boaz0:fixes_1718 branch from 7e115d3 to 6764a37 Apr 11, 2019
@tlabaj tlabaj self-assigned this Apr 15, 2019
@tlabaj
tlabaj approved these changes Apr 23, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 35815c2 into patternfly:master Apr 23, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Apr 23, 2019

Thanks you @tlabaj and @redallen

@boaz0 boaz0 deleted the boaz0:fixes_1718 branch Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.