Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): Enable highlighting and selecting text in popover. #1757

Merged
merged 1 commit into from May 6, 2019

Conversation

@dtaylor113
Copy link
Member

dtaylor113 commented Apr 12, 2019

Previously, cursor does turn to I-Beam (text), but cannot highlight or select the text in the Popover:
popover_not_working

With fix, can now highlight and select text:
popover_working

Fixes #1735

@dtaylor113 dtaylor113 requested review from jschuler, dlabaj and tlabaj Apr 12, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #1757 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1757   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         598      598           
  Lines        6629     6629           
  Branches       72       72           
=======================================
  Hits         5484     5484           
  Misses       1118     1118           
  Partials       27       27
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.34% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Tooltip/styles.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04aba61...0cbb7aa. Read the comment docs.

@dtaylor113

This comment has been minimized.

Copy link
Member Author

dtaylor113 commented Apr 15, 2019

Hi @jschuler, @dlabaj,
This is for openshift pr: openshift/console#1431

@dtaylor113

This comment has been minimized.

Copy link
Member Author

dtaylor113 commented Apr 16, 2019

Hi @jschuler, @dlabaj, please review when you get a moment, or reassign. -thanks :-)

@tlabaj
tlabaj approved these changes Apr 24, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@kmcfaul
kmcfaul approved these changes May 6, 2019
@tlabaj tlabaj merged commit 70be06f into master May 6, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@redallen redallen deleted the popover-copy branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.