Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(Select): Let user personalize icon in Select component #1768
Conversation
This comment has been minimized.
This comment has been minimized.
PatternFly-React preview: https://1768-pr-patternfly-react-patternfly.surge.sh |
1767
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Apr 15, 2019
•
This comment has been minimized.
This comment has been minimized.
@kmcfaul Can you take a look at this. |
This comment has been minimized.
This comment has been minimized.
Select is currently being rewritten in TypeScript, so we can address #1767 after it's rewritten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aljesusg commentedApr 15, 2019
Issue #1767
Add feature to Select Component
Let user personalize icon in toggle.
By default is the caret.