Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): Let user personalize icon in Select component #1768

Closed
wants to merge 1 commit into from

Conversation

@aljesusg
Copy link
Contributor

aljesusg commented Apr 15, 2019

Issue #1767

Add feature to Select Component

Let user personalize icon in toggle.
By default is the caret.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 15, 2019

@aljesusg aljesusg force-pushed the aljesusg:let_icon_in_select branch from d37dcc2 to fb854f4 Apr 15, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #1768 into master will increase coverage by 2.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1768      +/-   ##
==========================================
+ Coverage   82.77%   84.87%   +2.09%     
==========================================
  Files         601      355     -246     
  Lines        6642     3788    -2854     
  Branches       72        0      -72     
==========================================
- Hits         5498     3215    -2283     
+ Misses       1117      573     -544     
+ Partials       27        0      -27
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 ?
#patternflymisc ?
Impacted Files Coverage Δ
...4/react-core/src/layouts/Toolbar/ToolbarSection.js
...re/src/components/AboutModal/AboutModalBoxBrand.js
...4/react-charts/src/components/ChartPie/ChartPie.js
...s/patternfly-4/react-tokens/build/templates/esm.js
...t-core/src/components/Modal/ModalBoxCloseButton.js
.../react-core/src/components/Tooltip/TooltipArrow.js
...4/react-core/src/components/Select/SingleSelect.js
...ernfly-4/react-core/src/layouts/Gallery/Gallery.js
...ore/src/components/AboutModal/AboutModalBoxHero.js
...fly-4/react-core/src/components/Card/CardFooter.js
... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30204e4...fb854f4. Read the comment docs.

@dlabaj

This comment has been minimized.

Copy link
Contributor

dlabaj commented May 17, 2019

@kmcfaul Can you take a look at this.

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Jun 25, 2019

Select is currently being rewritten in TypeScript, so we can address #1767 after it's rewritten.

@redallen redallen closed this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.