Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clipboardcopy): fix docs #1821

Merged
merged 1 commit into from Apr 22, 2019
Merged

Conversation

@redallen
Copy link
Contributor

redallen commented Apr 22, 2019

What:

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 22, 2019

@rebeccaalpert rebeccaalpert self-requested a review Apr 22, 2019
Copy link
Member

rebeccaalpert left a comment

Looks good to me. I think the read-only example should have "This is read-only" for the text to match patternfly-next, but I'll open a separate issue for that (see #1822).

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #1821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1821   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         606      606           
  Lines        6688     6688           
  Branches       76       76           
=======================================
  Hits         5535     5535           
  Misses       1123     1123           
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.49% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a398042...a60bbc3. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #1821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1821   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         606      606           
  Lines        6688     6688           
  Branches       76       76           
=======================================
  Hits         5535     5535           
  Misses       1123     1123           
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.49% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a398042...a60bbc3. Read the comment docs.

@redallen redallen merged commit 2caf8a5 into patternfly:master Apr 22, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.