Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(clipboardcopy): change doc text #1823

Merged
merged 2 commits into from Apr 23, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Apr 22, 2019

What: Resolves #1822

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 22, 2019

Copy link
Contributor

tlabaj left a comment

I noticed that the ClipboardCopyProps are not exported in the index.d.ts file. Can you please add that with this PR. Also there are some unused imports in the ClipboardCopy.js file. Can you please clean them up with this PR as well? Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #1823 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1823   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         606      606           
  Lines        6688     6688           
  Branches       76       76           
=======================================
  Hits         5535     5535           
  Misses       1123     1123           
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.49% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...e/src/components/AboutModal/AboutModalBoxHeader.js 100% <0%> (ø) ⬆️
...ly-4/react-core/src/components/Page/PageSection.js 100% <0%> (ø) ⬆️
...react-core/src/components/AboutModal/AboutModal.js 70.83% <0%> (ø) ⬆️
...e/src/components/AboutModal/AboutModalContainer.js 88.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2caf8a5...3d8e7c5. Read the comment docs.

Copy link
Member

seanforyou23 left a comment

Changes look good. While testing this locally, I did notice the following error regarding ClipboardCopyProps.

Interface 'ClipboardCopyProps' incorrectly extends interface 'HTMLProps<HTMLDivElement>'.

Feel free to include those fixes here or in a separate PR.

@tlabaj
tlabaj approved these changes Apr 23, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

Copy link
Contributor

tlabaj left a comment

Looks good, could please make that one update from @seanforyou23

@tlabaj
tlabaj approved these changes Apr 23, 2019
Copy link
Contributor

tlabaj left a comment

LGTM. We can address the is @seanforyou23 in a separate PR.

@tlabaj tlabaj merged commit 959dfa1 into patternfly:master Apr 23, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.