Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clipboard): remove textarea from clipboard copy #1840

Merged
merged 2 commits into from Apr 24, 2019

Conversation

@dgutride
Copy link
Member

dgutride commented Apr 24, 2019

Fixes #1816

What:

Additional issues:

@dgutride dgutride force-pushed the dgutride:fix-clipboard-copy branch from e7d94d6 to a9b7b18 Apr 24, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 24, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #1840 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1840      +/-   ##
=========================================
+ Coverage    82.8%   82.8%   +<.01%     
=========================================
  Files         609     609              
  Lines        6711    6712       +1     
  Branches       81      81              
=========================================
+ Hits         5557    5558       +1     
  Misses       1123    1123              
  Partials       31      31
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.63% <75%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...re/src/components/ClipboardCopy/ExpandedContent.js 83.33% <75%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242c835...16a0710. Read the comment docs.

@mcoker

This comment has been minimized.

Copy link
Contributor

mcoker commented Apr 24, 2019

If you edit the content in the expandable example, if you start adding content anywhere other than the very beginning of the screen, after you type 1 character, the cursor moves back to the beginning of the expandable content.

Copy link
Contributor

dlabaj left a comment

LGTM

Copy link
Contributor

dlabaj left a comment

You have conflicts

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Apr 24, 2019

Just tried Github's web browser merging since the merge was super easy. Let's hope it works!

Edit: It worked. Magical.

@dlabaj
dlabaj approved these changes Apr 24, 2019
@dlabaj dlabaj merged commit 8bb26a2 into patternfly:master Apr 24, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.