Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): rename toggle export #1861

Merged
merged 3 commits into from Apr 26, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Apr 26, 2019

What: Closes #1844

Additional issues:

@redallen redallen changed the title fix(dropdown): rename export fix(dropdown): rename toggle export Apr 26, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 26, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 26, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@08a9ab5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1861   +/-   ##
=========================================
  Coverage          ?   82.59%           
=========================================
  Files             ?      621           
  Lines             ?     6844           
  Branches          ?       93           
=========================================
  Hits              ?     5653           
  Misses            ?     1151           
  Partials          ?       40
Flag Coverage Δ
#patternfly3 84.87% <ø> (?)
#patternfly4 79.29% <100%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...fly-4/react-core/src/components/Dropdown/Toggle.js 58.62% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a9ab5...5ec8933. Read the comment docs.

@mturley

This comment has been minimized.

Copy link
Collaborator

mturley commented Apr 26, 2019

@redallen looks like you still have 2 snapshots to update.

Copy link
Collaborator

mturley left a comment

👍

@dlabaj
dlabaj approved these changes Apr 26, 2019
@tlabaj
tlabaj approved these changes Apr 26, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj dlabaj merged commit e7088ce into patternfly:master Apr 26, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.