Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): Fix chart font stack to use PatternFly core sans-serif font stack #1865

Merged
merged 1 commit into from May 6, 2019

Conversation

@TheRealJon
Copy link
Contributor

TheRealJon commented Apr 26, 2019

Fixes #1864

What:
Use global_FontFamily_sans_serif variable for chart font stack. Also, correct misspelled 'TYPOGRAPHY' related variable names.

@TheRealJon TheRealJon requested a review from dlabrecq Apr 26, 2019
@TheRealJon

This comment has been minimized.

Copy link
Contributor Author

TheRealJon commented Apr 26, 2019

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 26, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #1865 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1865   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files         621      621           
  Lines        6844     6844           
  Branches       93       93           
=======================================
  Hits         5653     5653           
  Misses       1151     1151           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.29% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...t-charts/src/components/ChartTheme/theme-common.js 100% <ø> (ø) ⬆️
...rts/src/components/ChartTheme/theme-light-multi.js 100% <100%> (ø) ⬆️
...rts/src/components/ChartTheme/theme-light-green.js 100% <100%> (ø) ⬆️
...arts/src/components/ChartTheme/theme-light-blue.js 100% <100%> (ø) ⬆️
...arts/src/components/ChartTheme/theme-dark-green.js 100% <100%> (ø) ⬆️
...arts/src/components/ChartTheme/theme-dark-multi.js 100% <100%> (ø) ⬆️
...harts/src/components/ChartTheme/theme-dark-blue.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d588f0...dd08734. Read the comment docs.

@tlabaj
tlabaj approved these changes May 2, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit f2b4cc7 into patternfly:master May 6, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TheRealJon TheRealJon deleted the TheRealJon:issue-1864 branch Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.