Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): fix ListGroupItem import #1867

Merged
merged 1 commit into from Apr 29, 2019

Conversation

@glekner
Copy link
Contributor

glekner commented Apr 28, 2019

What:
Select doesn't work downstream, due to a ListGroupItem import error, this PR tries to fix it.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Apr 28, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 28, 2019

Codecov Report

Merging #1867 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1867   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         623      623           
  Lines        6870     6870           
  Branches       93       93           
=======================================
  Hits         5676     5676           
  Misses       1154     1154           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <100%> (ø) ⬆️
#patternfly4 79.37% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...y-react-extensions/src/components/Select/Select.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12dfa0...01df2aa. Read the comment docs.

@glekner

This comment has been minimized.

Copy link
Contributor Author

glekner commented Apr 29, 2019

@jeff-phillips-18 thoughts on this? is this the right solution?

@dgutride

This comment has been minimized.

Copy link
Member

dgutride commented Apr 29, 2019

@glekner - please open an issue for this

Copy link
Contributor

redallen left a comment

We should really fix the way we export ListGroupItem instead of this, but this will work for now.

@jeff-phillips-18

This comment has been minimized.

Copy link
Member

jeff-phillips-18 commented Apr 29, 2019

This fix is correct given the current build. We should find a better way to build so that we can import with the previous syntax but currently this is how it needs to be.

@jeff-phillips-18 jeff-phillips-18 merged commit f531e6b into patternfly:master Apr 29, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.