Skip to content

/patternfly-react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Add Date Picker component #1873

Merged
merged 1 commit into from Sep 6, 2019
Merged

feat(component): Add Date Picker component #1873

merged 1 commit into from Sep 6, 2019

Conversation

@MariaAga
Copy link
Contributor

MariaAga commented Apr 29, 2019

Splitted the date picker from:
#1420
@patternfly-build

This comment has been minimized.

Sign in to view
Copy link
Contributor

patternfly-build commented Apr 29, 2019

PatternFly-React preview: https://1873-pr-patternfly-react-patternfly.surge.sh
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

codecov-io commented Apr 29, 2019 •
edited

Codecov Report

❗️ No coverage uploaded for pull request base (master@0b5d403). Click here to learn what that means.
The diff coverage is 92.99%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1873   +/-   ##
=========================================
  Coverage          ?   82.74%           
=========================================
  Files             ?      637           
  Lines             ?     7051           
  Branches          ?      108           
=========================================
  Hits              ?     5834           
  Misses            ?     1167           
  Partials          ?       50
Flag Coverage Δ
#patternfly3 85.23% <92.99%> (?)
#patternfly4 79.05% <ø> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...onents/DateTimePicker/DateComponents/DecadeView.js 100% <100%> (ø)
...omponents/DateTimePicker/DateComponents/helpers.js 100% <100%> (ø)
...components/DateTimePicker/DateComponents/Header.js 100% <100%> (ø)
...nents/DateTimePicker/DateComponents/TodayButton.js 100% <100%> (ø)
...s/DateTimePicker/DateComponents/DecadeViewTable.js 100% <100%> (ø)
...mponents/DateTimePicker/DateComponents/YearView.js 100% <100%> (ø)
.../DateTimePicker/DateComponents/DecadeViewHeader.js 100% <100%> (ø)
...rc/components/DateTimePicker/DateComponents/Day.js 100% <100%> (ø)
...ponents/DateTimePicker/DateComponents/DateInput.js 72.72% <72.72%> (ø)
...ponents/DateTimePicker/DateComponents/MonthView.js 80.95% <80.95%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5d403...b9f311a. Read the comment docs.
@MariaAga MariaAga closed this Apr 29, 2019
@MariaAga MariaAga force-pushed the MariaAga:feat/DataPicker branch from 0c1d0a4 to f12dfa0 Apr 29, 2019
@MariaAga MariaAga reopened this Apr 29, 2019
@MariaAga MariaAga mentioned this pull request Apr 29, 2019
Merged
@jeff-phillips-18
jeff-phillips-18 reviewed May 14, 2019
View changes
...atternfly-3/patternfly-react/src/components/DateTimePicker/DatePicker.js Show resolved Hide resolved
...atternfly-3/patternfly-react/src/components/DateTimePicker/DatePicker.js Outdated Show resolved Hide resolved
...atternfly-3/patternfly-react/src/components/DateTimePicker/DatePicker.js Outdated Show resolved Hide resolved
@MariaAga MariaAga force-pushed the MariaAga:feat/DataPicker branch 2 times, most recently from 9172cae to bd8fcbc May 15, 2019
@laviro

This comment has been minimized.

Sign in to view
Copy link
Collaborator

laviro commented Jul 2, 2019

@MariaAga can you rebase ?
@MariaAga MariaAga force-pushed the MariaAga:feat/DataPicker branch from bd8fcbc to f58ee52 Jul 3, 2019
@MariaAga

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

MariaAga commented Jul 3, 2019

Rebased
@patternfly-build

This comment has been minimized.

Sign in to view
Copy link
Contributor

patternfly-build commented Jul 3, 2019

PatternFly-React preview: https://patternfly-react-pr-1873.surge.sh
@jeff-phillips-18
jeff-phillips-18 reviewed Jul 3, 2019
View changes
.../patternfly-react/src/components/DateTimePicker/DateComponents/Header.js Show resolved Hide resolved
@MariaAga MariaAga force-pushed the MariaAga:feat/DataPicker branch from f58ee52 to 67fc800 Jul 16, 2019
@MariaAga MariaAga force-pushed the MariaAga:feat/DataPicker branch from 67fc800 to dc05a61 Aug 11, 2019
@waldenraines

This comment has been minimized.

Sign in to view
Copy link
Collaborator

waldenraines commented Aug 15, 2019

@jeff-phillips-18 any other comments here?
@jeff-phillips-18
jeff-phillips-18 reviewed Aug 15, 2019
View changes
@dlabaj
dlabaj reviewed Aug 30, 2019
View changes
@tlabaj

This comment has been minimized.

Sign in to view
Copy link
Contributor

tlabaj commented Aug 30, 2019

@MariaAga this one should be ready to go in once you update your snapshots by running"yarn run test -u
@MariaAga
feat(component): Add Date Picker component
Loading status checks…
b9f311a
@MariaAga MariaAga dismissed stale reviews from dlabaj and jeff-phillips-18 via b9f311a Sep 1, 2019
@MariaAga MariaAga force-pushed the MariaAga:feat/DataPicker branch from dc05a61 to b9f311a Sep 1, 2019
@MariaAga

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

MariaAga commented Sep 1, 2019

Updated
@jeff-phillips-18
jeff-phillips-18 approved these changes Sep 3, 2019
View changes
@tlabaj
tlabaj approved these changes Sep 6, 2019
View changes
Copy link
Contributor

tlabaj left a comment

LGTM
@tlabaj tlabaj merged commit 5f6b467 into patternfly:master Sep 6, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18

@tlabaj tlabaj

@dlabaj dlabaj

Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
PF3 enhancement 🚀
Projects
None yet
Milestone
No milestone
8 participants
@MariaAga @patternfly-build @codecov-io @laviro @waldenraines @tlabaj @dlabaj @jeff-phillips-18
You can’t perform that action at this time.